From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web09.5254.1574422222585343546 for ; Fri, 22 Nov 2019 03:30:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ROPtQKJj; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574422221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W4epcFKz4/fjC/1syLUP3XLN8JVWaDrSH0HhqW8lggI=; b=ROPtQKJjEuv419x6KGxfo0/iHd0S2R8sFHAqWnrDGuuRmeJhcb3IZAabUZSFeOrOF4w57z 7aP4WR+KjXPTWbTxIalSoRFf8Zax3HCL7KDq4o/BojOQrwkDUuRArB/NEptCRI0XKIwRsF lU7LJ0tdkwpxD15iSvoJWqklZKRccMM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-301-fgf1cMCANQqUokMGlaFy_w-1; Fri, 22 Nov 2019 06:30:16 -0500 Received: by mail-wm1-f71.google.com with SMTP id f191so3300410wme.1 for ; Fri, 22 Nov 2019 03:30:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WkD0VPoPFDFHf17giSg/MkhQ+5XCg/dsrWm3r1pTvik=; b=UZV5toCdH1fglu8wO46nYc0fV9EJSGgXlt33OGcL4iLcegcQmcDe01e2XQUrsZOTeQ sx27DNcAtv/D9FwFBk0LpTpzWtIb3KGyDc8LKd5VLRPRl5jCpufSINKi4YVxVBTVhlqj Lc80TtMXcLRs7y8rBzERoF/NsPlgZ5/HMiib6PgFNJrWmBB64BZPoKwap4GLAPQcxhrT wTkIBPJZ/B5SkxfArECKKvBELZQ8sBfLXFBLTZnuGkWnRxCSsgktk5V4+GLKoYpkSp2c NjRUQrerslgjBJCG51VCgwts+K5kAniYdWPLajfRPwy4DNFF9ZGzrrBCnxTW6Q9XcOzz 7d7Q== X-Gm-Message-State: APjAAAXKk60+Ai2PYNEnHqPvsprTAfVUnVU4NbXqkt2PEuND3ggX7B0w 4DpZRP8agqBiyihQVZka0usDEc5kbTPMg11CZv0sVW7BbcSodbPA5jjPObRMz4dU/0Cop4q4Ozi uTbSBKQgnq7k8dA== X-Received: by 2002:a5d:5050:: with SMTP id h16mr18415754wrt.380.1574422215254; Fri, 22 Nov 2019 03:30:15 -0800 (PST) X-Google-Smtp-Source: APXvYqyrDIB8/eGvl1FH8zS6Ql9tVgx0V0oo7bNWGHNrGa8/RNfZeARp8YKds+rXjUYEsCilT1qOHA== X-Received: by 2002:a5d:5050:: with SMTP id h16mr18415727wrt.380.1574422215031; Fri, 22 Nov 2019 03:30:15 -0800 (PST) Return-Path: Received: from [192.168.1.35] (131.red-88-21-102.staticip.rima-tde.net. [88.21.102.131]) by smtp.gmail.com with ESMTPSA id h124sm3363119wmf.30.2019.11.22.03.30.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Nov 2019 03:30:14 -0800 (PST) Subject: Re: [edk2-devel] [Patch V2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore To: devel@edk2.groups.io, zhiguang.liu@intel.com Cc: Liming Gao , Jian J Wang , Hao A Wu , Leif Lindholm References: <20191122080726.36584-1-zhiguang.liu@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Fri, 22 Nov 2019 12:30:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191122080726.36584-1-zhiguang.liu@intel.com> X-MC-Unique: fgf1cMCANQqUokMGlaFy_w-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable Hi, On 11/22/19 9:07 AM, Zhiguang Liu wrote: > V1: >=20 > After unifying the definition of size_t, EBC compiler has failure. > So don't compile this inf file for EBC >=20 > V2: >=20 > Thanks for Leif's comment > Updated VALID_ARCHITECTURES in inf file >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2338 >=20 > Cc: Liming Gao > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Leif Lindholm > Reviewed-by: Liming Gao >=20 > Signed-off-by: Zhiguang Liu > --- > MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.in= f | 2 +- > MdeModulePkg/MdeModulePkg.dsc = | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecom= pressLib.inf b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecom= pressLib.inf > index 42b741c64b..4ed1d83a40 100644 > --- a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLi= b.inf > +++ b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLi= b.inf > @@ -25,7 +25,7 @@ > # > # The following information is for reference only and not required by t= he build tools. > # > -# VALID_ARCHITECTURES =3D IA32 X64 EBC > +# VALID_ARCHITECTURES =3D IA32 X64 AARCH64 ARM It looks you are doing 2 changes at once: - Add ARM/Aarch64 which were missing to VALID_ARCHITECTURES - Remove EBC (BZ#2338) Do you mind splitting this patch in 2 logical ones? (Maybe it is cleaner to first fix BZ#2338, then add the missing archs. > # > =20 > [Sources] > diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.ds= c > index 4320839abf..f7dbb27ce2 100644 > --- a/MdeModulePkg/MdeModulePkg.dsc > +++ b/MdeModulePkg/MdeModulePkg.dsc > @@ -299,7 +299,6 @@ > MdeModulePkg/Library/PeiDebugPrintHobLib/PeiDebugPrintHobLib.inf > MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerLi= bNull.inf > MdeModulePkg/Library/PlatformHookLibSerialPortPpi/PlatformHookLibSeri= alPortPpi.inf > - MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.i= nf > MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibRep= ortStatusCode.inf > MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebugPpi.inf > MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > @@ -433,6 +432,7 @@ > =20 > [Components.IA32, Components.X64, Components.ARM, Components.AARCH64] > MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompress= Lib.inf > + MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.i= nf > MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > MdeModulePkg/Core/Dxe/DxeMain.inf { > >=20