Re: [edk2-devel] [PATCH v2 0/2] ShellPkg/AcpiView: Adds HPET and WSMT parser

Re: [edk2-devel] [PATCH v2 0/2] ShellPkg/AcpiView: Adds HPET and WSMT parser

[Abdul Lateef Attar via groups.io]

Gentle reminder, please review and merge the patch.

On 08-03-2024 12:52, Abdul Lateef Attar via groups.io wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
>
> PR : https://github.com/tianocore/edk2/pull/5449
>
> Adds HPET and WSMT parser for acpiview.
> V2 delta changes:
>    Addressed review comments.
>    Added validation functions as per the comments.
>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Pierre Gondois  <pierre.gondois@arm.com>
> Abdul Lateef Attar (2):
>    ShellPkg/Acpiview: Adds HPET parser
>    ShellPkg/Acpiview: Adds ACPI WSMT Table parse
>
>   .../UefiShellAcpiViewCommandLib/AcpiParser.h  |  34 +++
>   .../Parsers/Hpet/HpetParser.c                 | 222 ++++++++++++++++++
>   .../Parsers/Wsmt/WsmtParser.c                 | 147 ++++++++++++
>   .../UefiShellAcpiViewCommandLib.c             |   2 +
>   .../UefiShellAcpiViewCommandLib.inf           |   2 +
>   5 files changed, 407 insertions(+)
>   create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Hpet/HpetParser.c
>   create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Wsmt/WsmtParser.c
>
> --
> 2.34.1
>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116945): https://edk2.groups.io/g/devel/message/116945
Mute This Topic: https://groups.io/mt/104804846/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/2] ShellPkg/AcpiView: Adds HPET and WSMT parser

[Gao, Zhichao]

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> Sent: Thursday, March 21, 2024 11:19 AM
> To: devel@edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
> Subject: Re: [edk2-devel] [PATCH v2 0/2] ShellPkg/AcpiView: Adds HPET and
> WSMT parser
> 
> Gentle reminder, please review and merge the patch.
> 
> On 08-03-2024 12:52, Abdul Lateef Attar via groups.io wrote:
> > Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> >
> >
> > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> >
> > PR : https://github.com/tianocore/edk2/pull/5449
> >
> > Adds HPET and WSMT parser for acpiview.
> > V2 delta changes:
> >    Addressed review comments.
> >    Added validation functions as per the comments.
> >
> > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > Cc: Pierre Gondois  <pierre.gondois@arm.com> Abdul Lateef Attar (2):
> >    ShellPkg/Acpiview: Adds HPET parser
> >    ShellPkg/Acpiview: Adds ACPI WSMT Table parse
> >
> >   .../UefiShellAcpiViewCommandLib/AcpiParser.h  |  34 +++
> >   .../Parsers/Hpet/HpetParser.c                 | 222 ++++++++++++++++++
> >   .../Parsers/Wsmt/WsmtParser.c                 | 147 ++++++++++++
> >   .../UefiShellAcpiViewCommandLib.c             |   2 +
> >   .../UefiShellAcpiViewCommandLib.inf           |   2 +
> >   5 files changed, 407 insertions(+)
> >   create mode 100644
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Hpet/HpetParser.c
> >   create mode 100644
> >
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Wsmt/WsmtParser
> .c
> >
> > --
> > 2.34.1
> >
> >
> >
> > 
> >
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117083): https://edk2.groups.io/g/devel/message/117083
Mute This Topic: https://groups.io/mt/104804846/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 0/2] ShellPkg/AcpiView: Adds HPET and WSMT parser

[Abdul Lateef Attar via groups.io]

From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>

PR : https://github.com/tianocore/edk2/pull/5449

Adds HPET and WSMT parser for acpiview.
V2 delta changes:
  Addressed review comments.
  Added validation functions as per the comments.

Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Pierre Gondois  <pierre.gondois@arm.com>
Abdul Lateef Attar (2):
  ShellPkg/Acpiview: Adds HPET parser
  ShellPkg/Acpiview: Adds ACPI WSMT Table parse

 .../UefiShellAcpiViewCommandLib/AcpiParser.h  |  34 +++
 .../Parsers/Hpet/HpetParser.c                 | 222 ++++++++++++++++++
 .../Parsers/Wsmt/WsmtParser.c                 | 147 ++++++++++++
 .../UefiShellAcpiViewCommandLib.c             |   2 +
 .../UefiShellAcpiViewCommandLib.inf           |   2 +
 5 files changed, 407 insertions(+)
 create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Hpet/HpetParser.c
 create mode 100644 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Wsmt/WsmtParser.c

-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116488): https://edk2.groups.io/g/devel/message/116488
Mute This Topic: https://groups.io/mt/104804846/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-