Re: [PATCH edk2-platforms v1 38/38] Platform/Hisilicon/D0x: Update version string to 18.08

[Ming <ming.huang@linaro.org>]

在 8/6/2018 6:03 PM, Leif Lindholm 写道:
> On Tue, Jul 24, 2018 at 03:09:22PM +0800, Ming Huang wrote:
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ming Huang <ming.huang@linaro.org>
>> ---
>>  Platform/Hisilicon/D03/D03.dsc | 2 +-
>>  Platform/Hisilicon/D05/D05.dsc | 2 +-
>>  Platform/Hisilicon/D06/D06.dsc | 4 ++--
>>  3 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
>> index 38548a0f23..8ed9c37a31 100644
>> --- a/Platform/Hisilicon/D03/D03.dsc
>> +++ b/Platform/Hisilicon/D03/D03.dsc
>> @@ -174,7 +174,7 @@
>>    !ifdef $(FIRMWARE_VER)
>>      gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)"
>>    !else
>> -    gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build 18.02 for Hisilicon D03"
>> +    gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build 18.08 for Hisilicon D03"
>>    !endif
>>  
>>    gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18"
>> diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc
>> index f2bbf27639..d9c0978f01 100644
>> --- a/Platform/Hisilicon/D05/D05.dsc
>> +++ b/Platform/Hisilicon/D05/D05.dsc
>> @@ -192,7 +192,7 @@
>>    !ifdef $(FIRMWARE_VER)
>>      gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)"
>>    !else
>> -    gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build 18.02 for Hisilicon D05"
>> +    gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build 18.08 for Hisilicon D05"
>>    !endif
>>  
>>    gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18"
>> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc
>> index 9a3128048e..4388812d44 100644
>> --- a/Platform/Hisilicon/D06/D06.dsc
>> +++ b/Platform/Hisilicon/D06/D06.dsc
>> @@ -166,12 +166,12 @@
>>    !ifdef $(FIRMWARE_VER)
>>      gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)"
>>    !else
>> -    gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D06 UEFI RC0 - B308 (V0.38)"
>> +    gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L""Development build 18.08 for Hisilicon D06"
> 
> I pointed this out before, but just to get it with the actual patch:
> there's an extra " in the line above that breaks the build when
> FIRMWARE_VER is not specified.
> 
> Drop that and:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

OK
Thanks.

> 
> 
>>    !endif
>>  
>>    gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18"
>>  
>> -  gHisiTokenSpaceGuid.PcdBiosVersionForBmc|L"0.38"
>> +  gHisiTokenSpaceGuid.PcdBiosVersionForBmc|L"0.42"
>>  
>>    gHisiTokenSpaceGuid.PcdSystemProductName|L"D06"
>>    gHisiTokenSpaceGuid.PcdSystemVersion|L"VER.A"
>> -- 
>> 2.17.0
>>