From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::544; helo=mail-pg1-x544.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 640BA210E3DFC for ; Thu, 9 Aug 2018 07:29:41 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id k3-v6so2839359pgq.5 for ; Thu, 09 Aug 2018 07:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=993/ZJ117dhrsY5Qw3Jm1Cno5Y6ydUcz5gmhMlvVnL8=; b=cliMkumSRf9zBaX9XMqjC4AR1U9UY/5TG+mQVazbCY6ZOrkgMEynlNDmdUo0HWQkVy uwLg6ZRf+Lae1YMPW+HJMulUWPeYje/MJpdhl+AbYa+uVwqZYE3r9SODuxwWxqkfmJJu s9NRtRpTPBlKnDaGB4+cp5dAggnwZuaruM7Ls= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=993/ZJ117dhrsY5Qw3Jm1Cno5Y6ydUcz5gmhMlvVnL8=; b=OZ081r02PbnX7nD+MfaWizF0ioKH2aOUCfUT4Gs4qcZmUTGY/1hcOHlOql+ACrvoCP jzhrqcd5Fxbg3K+xKnDLV+HkGjpA41hXiKRBS/qHq2scqkK0lAAtwh1zsjNyIPmV8P/9 AXp1P9tFDC0rEMqlCA8zo/eCej+YtXJjSdFgZW5FpmGZzMgecg7W/bBUeb2ujaTGSOj6 K007uAMSkOp9ZYMY2FJottxkqOcgFcAOvq+vzP2cr17BdO0eNeuQLR4yunH36ZFrbggO BX3eIZ5HbqlNFw9wSYH5lxo9A1P4vxqwoqXzqL3xNjLqsRrwKaoYKxPGjdgCSAsBF7TU MDMw== X-Gm-Message-State: AOUpUlGpzC8m16jniwCEmYvZofp01xhQY4D/8/lTsk8JFrxT+AQfIeBH h90mVdRTg2vjL8bcZEPln3hdcQ== X-Google-Smtp-Source: AA+uWPxKZzGTfDw3I4ajFMBa00OYKtJ1Xl8ssB31Tei2ethsxHkgC1uyey02fF2R1/LTK2lmewJKHQ== X-Received: by 2002:a63:ac57:: with SMTP id z23-v6mr2391809pgn.74.1533824981093; Thu, 09 Aug 2018 07:29:41 -0700 (PDT) Received: from [10.199.0.182] ([64.64.108.224]) by smtp.gmail.com with ESMTPSA id m26-v6sm17873873pfi.102.2018.08.09.07.29.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Aug 2018 07:29:40 -0700 (PDT) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, guoheyi@huawei.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org References: <20180724070922.63362-1-ming.huang@linaro.org> <20180724070922.63362-39-ming.huang@linaro.org> <20180806100325.iqfxp7towin2y5gn@bivouac.eciton.net> From: Ming Message-ID: Date: Thu, 9 Aug 2018 22:29:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180806100325.iqfxp7towin2y5gn@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v1 38/38] Platform/Hisilicon/D0x: Update version string to 18.08 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 14:29:41 -0000 Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit ÔÚ 8/6/2018 6:03 PM, Leif Lindholm дµÀ: > On Tue, Jul 24, 2018 at 03:09:22PM +0800, Ming Huang wrote: >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> --- >> Platform/Hisilicon/D03/D03.dsc | 2 +- >> Platform/Hisilicon/D05/D05.dsc | 2 +- >> Platform/Hisilicon/D06/D06.dsc | 4 ++-- >> 3 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc >> index 38548a0f23..8ed9c37a31 100644 >> --- a/Platform/Hisilicon/D03/D03.dsc >> +++ b/Platform/Hisilicon/D03/D03.dsc >> @@ -174,7 +174,7 @@ >> !ifdef $(FIRMWARE_VER) >> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" >> !else >> - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build 18.02 for Hisilicon D03" >> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build 18.08 for Hisilicon D03" >> !endif >> >> gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" >> diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc >> index f2bbf27639..d9c0978f01 100644 >> --- a/Platform/Hisilicon/D05/D05.dsc >> +++ b/Platform/Hisilicon/D05/D05.dsc >> @@ -192,7 +192,7 @@ >> !ifdef $(FIRMWARE_VER) >> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" >> !else >> - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build 18.02 for Hisilicon D05" >> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Development build 18.08 for Hisilicon D05" >> !endif >> >> gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" >> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc >> index 9a3128048e..4388812d44 100644 >> --- a/Platform/Hisilicon/D06/D06.dsc >> +++ b/Platform/Hisilicon/D06/D06.dsc >> @@ -166,12 +166,12 @@ >> !ifdef $(FIRMWARE_VER) >> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" >> !else >> - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D06 UEFI RC0 - B308 (V0.38)" >> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L""Development build 18.08 for Hisilicon D06" > > I pointed this out before, but just to get it with the actual patch: > there's an extra " in the line above that breaks the build when > FIRMWARE_VER is not specified. > > Drop that and: > Reviewed-by: Leif Lindholm OK Thanks. > > >> !endif >> >> gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" >> >> - gHisiTokenSpaceGuid.PcdBiosVersionForBmc|L"0.38" >> + gHisiTokenSpaceGuid.PcdBiosVersionForBmc|L"0.42" >> >> gHisiTokenSpaceGuid.PcdSystemProductName|L"D06" >> gHisiTokenSpaceGuid.PcdSystemVersion|L"VER.A" >> -- >> 2.17.0 >>