Re: [PATCH edk2-platforms 06/17] Silicon/Socionext: fix unused variable error NorFlashFvb

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 11/27/20 12:31 PM, Leif Lindholm wrote:
> When building in NOOPT mode, SynQuacer/Drivers/Fip006Dxe/NorFlashFvb.c
> fails to build with -Werror=unused-but-set-variable due to the Instance
> variable being set from the This pointer but never actually referenced.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Leif Lindholm <leif@nuviainc.com>

Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

> ---
> 
> Submitting as a single additional patch rather than a full v2.
> (Patch 17 is Ard's new one increasing the FV size for DeveloperBoxMm.)
> 
>   Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvb.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvb.c b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvb.c
> index 387789fb9782..48774e955faf 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvb.c
> +++ b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvb.c
> @@ -209,9 +209,6 @@ FvbGetAttributes(
>     )
>   {
>     EFI_FVB_ATTRIBUTES_2  FlashFvbAttributes;
> -  NOR_FLASH_INSTANCE *Instance;
> -
> -  Instance = INSTANCE_FROM_FVB_THIS(This);
>   
>     FlashFvbAttributes = EFI_FVB2_READ_ENABLED_CAP | EFI_FVB2_READ_STATUS |
>                          EFI_FVB2_WRITE_ENABLED_CAP | EFI_FVB2_WRITE_STATUS |
>