From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.115]) by mx.groups.io with SMTP id smtpd.web11.64851.1680006189373371337 for ; Tue, 28 Mar 2023 05:23:09 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=eGYU19Tv; spf=pass (domain: os.amperecomputing.com, ip: 40.107.212.115, mailfrom: tinhnguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QvWZ3vLf2XXRKAYiDDw2VVLZVQ/yJaJCeO+LOvcvN11YF9byBUuwsiYr5895JVnZxVquO3f2GJJqpXEVNAMiVDmg3PXVLdSrnQdqCtgqUdP3DJXA+Dluo04tMnEUeFV+cgB+7S7ls2AKlqwOZZ/wwNfo3TUY+94aGhABiqYqT+JM+v5z6+cW5t2N6N5mjDNyME8b5yBwFqkUv7JZ85XdYWljclM+H4jOFxpjSJL1TRHXcmXhFkyIX7QP7iTqGX3BTkzytT1N7aD/DS0Hb18ZxEPq60tVLq7ac6iFf6ObOAmsqtec0JiJwkt+0OGk99fkb3LoAvf/4DD4EPVF97GlUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gFbTlIyTXQVvKeHGVhoMCfxojov9w0ejlsvkOh5vcIg=; b=hR4RupjRnQe4tj/6kE4nkPT8GQGQzwoCvEQ++m/6mEwdzYHRU1gDS5jkNAbJA21bIxb9fSbillNPVchRmtTpVAf4+G1wYWADKDGatScjQZ9sqEhJXrqToc9O6J3Z90hdZDVapheXtkxWz7QL4xWGRzstYR8CDNEPZ9RJx8tfwmzAlU2O6EhchToJJmqdmKmlhvnXnqyo31tkVmK6/qyC6iRTtA9QP5+T6chbgs1AAnUxKJqhtodMhVFi79FiVd/D/21FHW90khojr1Iljrkymz7o3qc3OOVhae1p1QLPoBZ5p9yA7rpXsjP8l7a4EUMUWrULRXlseCP+ZyYX9Ewi4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gFbTlIyTXQVvKeHGVhoMCfxojov9w0ejlsvkOh5vcIg=; b=eGYU19TvtyVTOdxZZ0luR7bOYkR6Qxp7iJQso4Tw+9gZzwwVu4uPi3+CFm3wxLTXUujvrRjAKpMYvKiYkea7kTyqUOivx78kQ24AbPFb0kry950bbjCkV/8b2UbvqiRRqYHTVrM3fL46oGmJpU2FWgyibu0v4gXm/OdniHMVu90= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from MWHPR0101MB2942.prod.exchangelabs.com (2603:10b6:301:2e::14) by CH2PR01MB6007.prod.exchangelabs.com (2603:10b6:610:47::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.18; Tue, 28 Mar 2023 12:23:05 +0000 Received: from MWHPR0101MB2942.prod.exchangelabs.com ([fe80::1d06:a51a:ca3d:c2f6]) by MWHPR0101MB2942.prod.exchangelabs.com ([fe80::1d06:a51a:ca3d:c2f6%4]) with mapi id 15.20.6178.041; Tue, 28 Mar 2023 12:23:05 +0000 Message-ID: Date: Tue, 28 Mar 2023 19:22:58 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-devel] [PATCH v4 8/9] ManageabilityPkg: Add IpmiProtocol to Manageability Package To: devel@edk2.groups.io, abner.chang@amd.com CC: Liming Gao , Isaac Oram , Nate DeSimone , Abdul Lateef Attar , Nickle Wang , Igor Kulchytskyy References: <20230322024840.1629-1-abner.chang@amd.com> <20230322024840.1629-8-abner.chang@amd.com> From: "Tinh Nguyen" In-Reply-To: <20230322024840.1629-8-abner.chang@amd.com> X-ClientProxiedBy: SG2PR04CA0184.apcprd04.prod.outlook.com (2603:1096:4:14::22) To MWHPR0101MB2942.prod.exchangelabs.com (2603:10b6:301:2e::14) Return-Path: tinhnguyen@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR0101MB2942:EE_|CH2PR01MB6007:EE_ X-MS-Office365-Filtering-Correlation-Id: 21ccfee3-9541-49e7-490c-08db2f872e97 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j50VvRXZf0BNwyZSNPllT0IcW6N5kIez4maNGwseroEdZgF2AJXA8irmUaR9tZ3d4yk1jRn1Hz+WYShokMXQPmJ9xBQzR3RX2Je0MgMjcAcwvHA5M8HveltCGUd8CJrbjNC2TeMSGCsQs+PIE2r3daksRAT+tN4ANXvx70DevmTav1f0n/zSjG3YoG52pw6FyhketYfoJN2vAy2MA+kUnKWbeTv2x2bdfe+vfaS84QjYM2ghQ0VEl+1pw4/aoUP3KORdNL53/WOewCAGGb2tIFg7ukisIBusEsXmT0ZfClvRSKhcAMMXYE2+Yqg8/WzSi5ZH1+f46LTZZkDh1/vr1l/3ia0rlRFny4ovtCW5XG9jKMjmw/NgDLCI/S61h+vFcYFdewVU7Pj5JYB+IsV+U+V2qmzaNLdirJKU2F6UXWRwe/q3t0Xn+R0l/YfT1OK4AlsW+fwkoUVDqH/HkPfB3D+Zt9N1MDcRpVxzF/e/DXUB97tj+pueVKd/kv1nHs8ASNE4OiXVlgnpyiuV7qLnUDXeqLjSokv4ewZFOZyvNVzBV5kpemwBttQMfljWlRihr42frT2y+onPDtb9xHj+w5T2C7k0jEaP14Da+vsBi/Vg4CM++WHEcIaNj8RjQg7P X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR0101MB2942.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(346002)(39850400004)(136003)(396003)(451199021)(54906003)(316002)(6486002)(4326008)(41300700001)(478600001)(38100700002)(83170400001)(8936002)(8676002)(66556008)(66476007)(66946007)(42882007)(6666004)(53546011)(6506007)(26005)(6512007)(186003)(2616005)(31696002)(5660300002)(2906002)(31686004)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?In7SV61dlyEKPebXSZstpddpWFTnm30c9EAu9wKJLZKnbVnN/b6rmCVBZXwD?= =?us-ascii?Q?i0zWON6KtYkY1sPokBp8N9ZGlDadeHK8VqtUkybl2f8fZYQgMmXqwvA8s0MM?= =?us-ascii?Q?4+YrEFMcnv5O8lclU7RL04+0wAWmP07pAJXCVoSuNZa8qlM7Id3a+RuYPajc?= =?us-ascii?Q?Mbj33P8uPA5PlnD5p7ur4cdxySIth1V3P4cODjtngo7xb7JYDnYJTuwrm9OD?= =?us-ascii?Q?hMsG+GBJnf/cQU6i3AF2f8CmWZWPPeV1/bA+J3U2nFlxbiehMwqabf+05U2v?= =?us-ascii?Q?KGrAWCZ0Op3aNnbFDEqGjdUV09z4FxRA6ou0a0fsO7ZcHdzBnN88Xv73/dd8?= =?us-ascii?Q?4pCS2N9z2MG2dNqi7XUuhkVW6VciodmZ9xB2Iq27lqgj07QiZmAYZOEBNhpx?= =?us-ascii?Q?DiNE8TobL8U+MPAxTwHHlfoP7Eba2LnRf8tVVcYYjZAp9T7JbWZSz3YKbJDY?= =?us-ascii?Q?f1uSBvSDdafPqosJMPe3SmIGfNSlT37DNlgCGdNc4femhKqZDOiNZRyS+C3i?= =?us-ascii?Q?drqAnK14ZATRDBjOiSp8l+/O8H0/KjHPSYzg2X4h7Hqn/FQBBG98rd8s1pMt?= =?us-ascii?Q?7TvqD6QdUMfizh875R1hoEqVXEFAkDTNiFAn3PQWXdYDj8le8e+2l9sCTzrH?= =?us-ascii?Q?dhwgrZBvZrW0WbpFSv6Pa5LrLozXPpFxprh4V5vHLxRzpeLNkhHdj5mSlFoF?= =?us-ascii?Q?R9anuxivZThZxbuyHQY3mBJP0nZzP7rM30TCwpBjGEaulJVufnRxV9sp8gj7?= =?us-ascii?Q?/VZrBVbyg3Ii5HBrzmmPv2yImGvHWnQSIOvjbVVRpTuF8vFo2X/w3kxNI0P7?= =?us-ascii?Q?2ZP6Ztog7ayfx0tCxuJwQHPRt9/PPuczvpuigT+5uQLCFFk34nlHfWLCZDa6?= =?us-ascii?Q?G6dtvEctpvPNhqHYEzIWLsuUXz1vwOjbsDOMjvAWlfSwraYoLyUK2KinqEke?= =?us-ascii?Q?SCzuQ6FvnPWU35tyhKhWSovZiQ44NWw1bxfY4qw3xBhEqsyn7uUoyJQ8aoBx?= =?us-ascii?Q?nG7jyrXbkfPjAS3KSbcxHw+fNggYVPwJXcds7pH8wxT6lxv4Vjtor5w9jz2R?= =?us-ascii?Q?C1wd1LUxWLEpnylkaTFIIqJ/COKf+QLTCc8a9+D6AMPhcBDcvKbSzeDJb1pn?= =?us-ascii?Q?VYq9yOKuWGVs7MxzyHypMsCasH6wyYHDk9VC/iQe5nU6OjyM2euIVu6cQCYh?= =?us-ascii?Q?mh3LwWjrKso2398EAHUs+JLApGHTKsidNrzzba+xyZkc02LEOgeX8UNNfspS?= =?us-ascii?Q?MH0Pwo2IT6NjuvjtJpsAl0eSt+ebDm2L6BJZ1TPHbyhsK3AL6XcKxKCdOdXk?= =?us-ascii?Q?EyL+OVqBqwIHsqhzYZRE2jy/UbEmDLgIDpqnwDJJ1ghF1M/Qm81aIKw6ayMQ?= =?us-ascii?Q?8Ry8fowV4SYb1SOBLNA1W2iNpA6tTWs/Nl48YEG8S1Dy/sOJtrc0kFThPt53?= =?us-ascii?Q?7u4yGzKopAhFIIOlqhnVrt3UvIkNo6rbkEoG767Yt8cUbg039sVYIN+SA5re?= =?us-ascii?Q?Ddyk2YkhCO98EcGnnokkF1daKj/5KWuo4LaxiIJ1VNzC5PSFFq3htuZQsCAB?= =?us-ascii?Q?vk50neoIz2dFpzZs3SoqKC9DB1FwC3yVJ9/Cba771TFiKQKEz2nu6fNxdPaW?= =?us-ascii?Q?+qywC3QqdSrWaEhtniy8pHY=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21ccfee3-9541-49e7-490c-08db2f872e97 X-MS-Exchange-CrossTenant-AuthSource: MWHPR0101MB2942.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2023 12:23:05.5095 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CG5fKL12eFcg5frzOeYPY9o5f0g6ynxlBBVUc9PN4Wtskz+NWjkWjT8xj960qQLfCMkqg+dFYYtpso9GxV57bbwwdMmBDTtVLMp9swYSwy5ZDDz6y75QDfd+R2lM6Opu X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR01MB6007 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Abner, The DXE and PEI modules should work on aarch64. Please see my suggestion below. On 3/22/2023 9:48 AM, Chang, Abner via groups.io wrote: > From: Abner Chang > > Add Ipmi Protocol/Ppi/SMM modules to ManageabilityPkg. > > Signed-off-by: Abner Chang > Cc: Liming Gao > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Abdul Lateef Attar > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Reviewed-by: Nickle Wang > --- > Features/ManageabilityPkg/Include/Dsc/Manageability.dsc | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc b/Fe= atures/ManageabilityPkg/Include/Dsc/Manageability.dsc > index 994c93f17c..0d868fdf4a 100644 > --- a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc > +++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc > @@ -16,3 +16,10 @@ > NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf =C2=A0 ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf =C2=A0 BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf [LibraryClasses.AARCH64.PEIM] PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiSer= vicesTablePointerLib.inf > =20 > +[Components.IA32] > + ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf > + > +[Components.X64] > + ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf > + ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf > + [Components.IA32, Components.AARCH64] =C2=A0 ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf [Components.X64, Components.AARCH64] =C2=A0 ManageabilityPkg/Universal/IpmiProtocol/Dxe/IpmiProtocolDxe.inf [Components.X64] =C2=A0 ManageabilityPkg/Universal/IpmiProtocol/Smm/IpmiProtocolSmm.inf