From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web08.1129.1616435224564263363 for ; Mon, 22 Mar 2021 10:47:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=J+G3SrmQ; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616435223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GhiwFjycUCP2NsNnhwa20EyUvVf1AKE0ri/xKNjn870=; b=J+G3SrmQ42oJaf9UQk8rfySZPl4RpzlFx6uQFmPjiX9nWwRnofdpim2YfXEnHmxBiiFdto Sr9kgVglxW+2rjf2vBbztZApUo4rvj0KTZf4UH7RIe1BrmE4TMKCRb2S5VOt+MwsnzeT14 lmaBrS/4Ce/5xuu7RI1uFEeSYVdjwyI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-377-jEm-JD5gPXuWA2HZWjN45A-1; Mon, 22 Mar 2021 13:47:00 -0400 X-MC-Unique: jEm-JD5gPXuWA2HZWjN45A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 74DD55B361; Mon, 22 Mar 2021 17:46:58 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-223.ams2.redhat.com [10.36.115.223]) by smtp.corp.redhat.com (Postfix) with ESMTP id E3F8519C87; Mon, 22 Mar 2021 17:46:56 +0000 (UTC) Subject: Re: [patch V2 02/29] MdePkg: Add MdeLibs.dsc.inc file to MdePkg To: Dandan Bi , devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu References: <20210322080941.6780-1-dandan.bi@intel.com> <20210322080941.6780-3-dandan.bi@intel.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 22 Mar 2021 18:46:55 +0100 MIME-Version: 1.0 In-Reply-To: <20210322080941.6780-3-dandan.bi@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/22/21 09:09, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > > MdeLibs.dsc.inc is added for some default libraries provided by MdePkg. > Platform can include MdeLibs.dsc.inc file to avoid some potential > incompatible changes to platform dsc file in future. > > Only add RegisterFilterLib into it as the first version of MdeLibs.dsc.inc. > Can update and maintain MdeLibs.dsc.inc gradually later. > > "MdeLibs.dsc.inc" for the [LibraryClasses*] section(s) > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Laszlo Ersek > Signed-off-by: Dandan Bi > --- > MdePkg/MdeLibs.dsc.inc | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 MdePkg/MdeLibs.dsc.inc > > diff --git a/MdePkg/MdeLibs.dsc.inc b/MdePkg/MdeLibs.dsc.inc > new file mode 100644 > index 0000000000..75e516c21a > --- /dev/null > +++ b/MdePkg/MdeLibs.dsc.inc > @@ -0,0 +1,14 @@ > +## @file > +# Mde DSC include file for [LibraryClasses*] section of all Architectures. > +# > +# This file can be included to the [LibraryClasses*] section(s) of a platform DSC file > +# by using "!include MdePkg/MdeLibs.dsc.inc" to specify the library instances > +# of some EDKII basic/common library classes. I think Liming or Mike might want to propose improved wording for "basic/common". Personally I'm fine with "basic/common", I just think a more precise definition for MdePkg's content / scope might exist. With or without a more precise expression for "basic/common": Reviewed-by: Laszlo Ersek Thanks Laszlo > +# > +# Copyright (c) 2021, Intel Corporation. All rights reserved.
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > + RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf >