From: Laszlo Ersek <lersek@redhat.com>
To: Long Qin <qin.long@intel.com>, ting.ye@intel.com
Cc: edk2-devel@lists.01.org
Subject: Re: [PATCH v2 2/2] CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0h
Date: Fri, 13 Apr 2018 22:07:38 +0200 [thread overview]
Message-ID: <fdddb54f-6c5c-7617-1aae-90495c57baa3@redhat.com> (raw)
In-Reply-To: <20180412030801.14216-3-qin.long@intel.com>
On 04/12/18 05:08, Long Qin wrote:
> (https://bugzilla.tianocore.org/show_bug.cgi?id=927)
>
> (V2 Update:
> Removing the wrong "--remote" option from git submodule update
> command in this commit message. Thanks Leszlo's clarification
> to correct this)
(1) "Laszlo", not "Leszlo" :)
>
> Update OpenSSL version to 1.1.0h release (27-Mar-2018) to include the
> fix for CVE-2018-0739 issue (Handling of crafted recursive ASN.1
> structures can cause a stack overflow and resulting denial of service,
> Refer to https://www.openssl.org/news/secadv/20180327.txt for more
> information).
>
> Please note "git pull" will not update the submodule repository.
> use the following commend to make your existing submodule track this
> update:
> $ git submodule update -–recursive
(2) OK, so this is a tricky one. The "--recursive" option starts with
two hyphen characters (ASCII 0x2D). However, the string above starts
with a hyphen (ASCII 0x2D) and then a unicode EN DASH codepoint
(U+2013). Please replace it with a normal hyphen.
More below:
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ye Ting <ting.ye@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Long Qin <qin.long@intel.com>
> ---
> CryptoPkg/Library/OpensslLib/openssl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/CryptoPkg/Library/OpensslLib/openssl b/CryptoPkg/Library/OpensslLib/openssl
> index b2758a2292..d4e4bd2a81 160000
> --- a/CryptoPkg/Library/OpensslLib/openssl
> +++ b/CryptoPkg/Library/OpensslLib/openssl
> @@ -1 +1 @@
> -Subproject commit b2758a2292aceda93e9f44c219b94fe21bb9a650
> +Subproject commit d4e4bd2a8163f355fa8a3884077eaec7adc75ff7
>
With the commit msg updates:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
I also tested this patch, with an off-disk Secure Boot, and an HTTPS
boot. Both worked fine.
Tested-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
next prev parent reply other threads:[~2018-04-13 20:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 3:07 [PATCH v2 0/2] Update OpenSSL version to 1.1.0h Long Qin
2018-04-12 3:08 ` [PATCH v2 1/2] CryptoPkg/OpensslLib: Fix the documentation about submodule update Long Qin
2018-04-12 9:55 ` Laszlo Ersek
2018-04-12 10:03 ` Long, Qin
2018-04-12 12:05 ` Laszlo Ersek
2018-04-13 20:03 ` Laszlo Ersek
2018-04-12 3:08 ` [PATCH v2 2/2] CryptoPkg/OpensslLib: Update OpenSSL version to 1.1.0h Long Qin
2018-04-13 20:07 ` Laszlo Ersek [this message]
2018-04-15 13:17 ` Long, Qin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdddb54f-6c5c-7617-1aae-90495c57baa3@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox