Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe

["Rebecca Cran" <rebecca@nuviainc.com>]

Hi Sami,

I've been looking through the design document again, and was wondering 
if the work I previously did will just slot in?

Were you thinking the "RngLib|RNDR" would go into ArmPkg (since it's not 
labeled as being in BaseRngLib)? Or would it still make sense to 
refactor MdePkg/Library/BaseRngLib to support both x86 (using RDRAND) 
and aarch64 (using RNDR)?

-- 
Rebecca Cran 
 


On 4/22/21 3:30 AM, Sami Mujawar wrote:
> Hi Rebecca,
> 
> I have been working on the following modules (See slide 11 in “EDKII - 
> Proposed update to RNG implementation.pdf 
> <https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf>”):
> 
>  1. TrngLib|FwTrnglib (Arm Firmware TRNG)
>  2. DrbgLib stack – with support for DrbgAlgorithmLib|CRT_DRBG &
>     AesLib|ArmAesInstructionLib.
> 
> I plan to post patches for (a) in the next fortnight. Following this I 
> plan to update the proposal with the interface definitions for the 
> various library interfaces in the DrbgLib Stack.
> 
> I have not looked at RngLib|RNDR as I believe you were interested in 
> implementing the part. Kindly let me know if you plan to implement this 
> and the platform you would be using for testing. It looks like the 
> FVP_Base_AEMv8A-AEMv8A and the FVP-RevC models support RNDR, so these 
> could be used for testing as well. Please feel free to get in touch 
> should you need any help with the model parameters or if you face any 
> issues.
> 
> Regards,
> 
> Sami Mujawar
> 
> *From: *Rebecca Cran <rebecca@nuviainc.com>
> *Date: *Tuesday, 20 April 2021 at 21:04
> *To: *Sami Mujawar <Sami.Mujawar@arm.com>, devel@edk2.groups.io 
> <devel@edk2.groups.io>, Samer El-Haj-Mahmoud 
> <Samer.El-Haj-Mahmoud@arm.com>, Ard Biesheuvel <Ard.Biesheuvel@arm.com>, 
> leif@nuviainc.com <leif@nuviainc.com>
> *Cc: *rfc@edk2.groups.io <rfc@edk2.groups.io>, Jiewen Yao 
> <jiewen.yao@intel.com>, Rahul Kumar <rahul1.kumar@intel.com>, nd 
> <nd@arm.com>, Jose Marinho <Jose.Marinho@arm.com>
> *Subject: *Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to 
> RngDxe
> 
> Hi Sami,
> 
> I was wondering if you're still collecting feedback on the design, or if
> you have a plan and schedule for the implementation?
> 
> -- 
> Rebecca Cran
> 
> On 1/15/21 7:51 PM, Sami Mujawar wrote:
>  > Hi All,
>  >
>  > I have shared some initial thoughts on the RNG implementation updates 
> at 
> https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf 
> <https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf>
>  >
>  > Kindly let me know your feedback or if you have any queries.
>  >
>  > Regards,
>  >
>  > Sami Mujawar
>  >
>  > -----Original Message-----
>  > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of 
> Rebecca Cran via groups.io
>  > Sent: 14 January 2021 09:05 PM
>  > To: Sami Mujawar <Sami.Mujawar@arm.com>; devel@edk2.groups.io; Samer 
> El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Ard Biesheuvel 
> <Ard.Biesheuvel@arm.com>; leif@nuviainc.com
>  > Cc: rfc@edk2.groups.io; Jiewen Yao <jiewen.yao@intel.com>; Rahul 
> Kumar <rahul1.kumar@intel.com>; nd <nd@arm.com>
>  > Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to 
> RngDxe
>  >
>  > On 12/10/20 4:26 AM, Sami Mujawar wrote:
>  >
>  >> I am working on the TRNG FW API interface and will share more details
>  >> for the discussion soon.
>  >>
>  >> We had some thoughts about streamlining the RngDxe implementations and
>  >> would like to share some diagrams for the discussion.
>  >>
>  >> My diagrams are in Visio that I can export as JPG images. However, I am
>  >> open to switching to any other suggested tool.
>  >
>  > Hi Sami,
>  >
>  > I don't see any further discussions on this. Have you made any progress
>  > with sharing the design documents or scheduling a review?
>  >
>