From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by mx.groups.io with SMTP id smtpd.web10.444.1619472527569076262 for ; Mon, 26 Apr 2021 14:28:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=FuU/POCP; spf=pass (domain: nuviainc.com, ip: 209.85.219.51, mailfrom: rebecca@nuviainc.com) Received: by mail-qv1-f51.google.com with SMTP id x14so4693999qvr.5 for ; Mon, 26 Apr 2021 14:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CiJ77ChCL1a8ofb/uVC2FIQFThwHGDKq8pEJCq5avSY=; b=FuU/POCPt9WNoUgKbImQxGNvtMkIZkyA1buhz5O0+HT0liyQEBZqMX4y/Q4XDR0hlm I9SmH8HWQVntVRCzQvDZUbb5oA6bkT1jJNKy6Ua5DSzK3UOB4Sv2H/bYlNVSuC6kyJ5P APf3Ub3luCCtFDcqotPVReIg5KCzkghS0f+j6UYFxgZ/gbpmclJIIEjxAqB5P1IhfM45 +m8Y/A1VJeoaLesbX1lZIJgYp3IvdLws/gVtzkEku9CAy3nKPEWDmgyMvVq3CMXMd2aK fr+KyMHtQ/ONDJK796mXAAsLiDT8kPwZAz1fdOvH4FsyYnHe2rYoJrDyjE1bF4etzu31 OhGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CiJ77ChCL1a8ofb/uVC2FIQFThwHGDKq8pEJCq5avSY=; b=RfMUWCv+xBnfADeN1GCi91T/aBllB4AwgZDztKNo3yI2OUIWvgk2kC9bs21iDpRFOC KxABsHpYmr7OSWeST7tcYvsNFR79qiu1pXsC6/aKH/ofPqqcNJ3SakVv32VbgdJuRokg UbnDEytlHDtVYVDkzzoBkJo7tXYwaL6RsEHgZNHlVbfpz0252L2ME5rdefc8ZiGWqng3 BlICdPVmQkIcBhOjiy/OTR9Y5zTWrDXeS2OZUrP2LufIU+6WfKyxoKPapy/m8W9vwax0 q9+V+pCwEEm9/lz+ZlgNayK68HTELvB0equtEFc4Fbwc2QnxWqo/LBYjVXaF2t5fkV0B ojbw== X-Gm-Message-State: AOAM533Gr2EaMrtubOrjpk3e21vIS+Ds+JClsyNcilW13vXlF1JXrnTH nOJiQf5Po7AFoQuOi65huHvaGg== X-Google-Smtp-Source: ABdhPJxgVe8+wpb4kTySwRoBsmekJ+RdC1AXo8phXLPCJX1d6iuJnpF1Bz2OmAFqxh24U2VP1qAp7g== X-Received: by 2002:ad4:5bef:: with SMTP id k15mr19575971qvc.16.1619472526650; Mon, 26 Apr 2021 14:28:46 -0700 (PDT) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id d207sm1238619qke.59.2021.04.26.14.28.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Apr 2021 14:28:46 -0700 (PDT) Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to RngDxe To: Sami Mujawar , "devel@edk2.groups.io" , Samer El-Haj-Mahmoud , Ard Biesheuvel , "leif@nuviainc.com" Cc: "rfc@edk2.groups.io" , Jiewen Yao , Rahul Kumar , nd , Jose Marinho References: <70a4f9e7-952c-cf05-bca7-009ee5b2cd3f@nuviainc.com> <06a2aa56-d4ec-3db2-0e82-12211daa5fa7@nuviainc.com> <985081eb-5e3e-fc33-6afa-c9c121412973@nuviainc.com> From: "Rebecca Cran" Message-ID: Date: Mon, 26 Apr 2021 15:28:44 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Sami, I've been looking through the design document again, and was wondering if the work I previously did will just slot in? Were you thinking the "RngLib|RNDR" would go into ArmPkg (since it's not labeled as being in BaseRngLib)? Or would it still make sense to refactor MdePkg/Library/BaseRngLib to support both x86 (using RDRAND) and aarch64 (using RNDR)? -- Rebecca Cran On 4/22/21 3:30 AM, Sami Mujawar wrote: > Hi Rebecca, > > I have been working on the following modules (See slide 11 in “EDKII - > Proposed update to RNG implementation.pdf > ”): > > 1. TrngLib|FwTrnglib (Arm Firmware TRNG) > 2. DrbgLib stack – with support for DrbgAlgorithmLib|CRT_DRBG & > AesLib|ArmAesInstructionLib. > > I plan to post patches for (a) in the next fortnight. Following this I > plan to update the proposal with the interface definitions for the > various library interfaces in the DrbgLib Stack. > > I have not looked at RngLib|RNDR as I believe you were interested in > implementing the part. Kindly let me know if you plan to implement this > and the platform you would be using for testing. It looks like the > FVP_Base_AEMv8A-AEMv8A and the FVP-RevC models support RNDR, so these > could be used for testing as well. Please feel free to get in touch > should you need any help with the model parameters or if you face any > issues. > > Regards, > > Sami Mujawar > > *From: *Rebecca Cran > *Date: *Tuesday, 20 April 2021 at 21:04 > *To: *Sami Mujawar , devel@edk2.groups.io > , Samer El-Haj-Mahmoud > , Ard Biesheuvel , > leif@nuviainc.com > *Cc: *rfc@edk2.groups.io , Jiewen Yao > , Rahul Kumar , nd > , Jose Marinho > *Subject: *Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to > RngDxe > > Hi Sami, > > I was wondering if you're still collecting feedback on the design, or if > you have a plan and schedule for the implementation? > > -- > Rebecca Cran > > On 1/15/21 7:51 PM, Sami Mujawar wrote: > > Hi All, > > > > I have shared some initial thoughts on the RNG implementation updates > at > https://edk2.groups.io/g/devel/files/Designs/2021/0116/EDKII%20-%20Proposed%20update%20to%20RNG%20implementation.pdf > > > > > Kindly let me know your feedback or if you have any queries. > > > > Regards, > > > > Sami Mujawar > > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > Rebecca Cran via groups.io > > Sent: 14 January 2021 09:05 PM > > To: Sami Mujawar ; devel@edk2.groups.io; Samer > El-Haj-Mahmoud ; Ard Biesheuvel > ; leif@nuviainc.com > > Cc: rfc@edk2.groups.io; Jiewen Yao ; Rahul > Kumar ; nd > > Subject: Re: [edk2-devel] RFC: Adding support for ARM (RNDR etc.) to > RngDxe > > > > On 12/10/20 4:26 AM, Sami Mujawar wrote: > > > >> I am working on the TRNG FW API interface and will share more details > >> for the discussion soon. > >> > >> We had some thoughts about streamlining the RngDxe implementations and > >> would like to share some diagrams for the discussion. > >> > >> My diagrams are in Visio that I can export as JPG images. However, I am > >> open to switching to any other suggested tool. > > > > Hi Sami, > > > > I don't see any further discussions on this. Have you made any progress > > with sharing the design documents or scheduling a review? > > >