From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.4062.1617782490739365355 for ; Wed, 07 Apr 2021 01:01:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UnJOTGav; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617782489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gANcOduiS5qwqHjaF+KRPhsM0SyVb9ZQmC/3XolK80E=; b=UnJOTGav5JXYBD7+YGdph81ICx4rxVmO36OFWozEznzgMoFjyeBrb1hNC3P+DQnjbBWz7e xR0+T6lEAcsJffBdU/2Q+UcmgphocDpS0QzEvWUNlFpoQ4nwCE5WKTHDvQIRItzLEbfTKV FlvyUbioibpWwJvZIt/qkDYShBYlZKU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-184-5ZccmnLQO5CYOnHN6o16WQ-1; Wed, 07 Apr 2021 04:01:25 -0400 X-MC-Unique: 5ZccmnLQO5CYOnHN6o16WQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7782C18BA280; Wed, 7 Apr 2021 08:01:24 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-38.ams2.redhat.com [10.36.112.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 158AF5D741; Wed, 7 Apr 2021 08:01:21 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 4/7] OvmfPkg/IndustryStandard: Introduce PageTable.h To: devel@edk2.groups.io, thomas.lendacky@amd.com, Anthony PERARD Cc: xen-devel@lists.xenproject.org, Jordan Justen , Ard Biesheuvel , Julien Grall , Brijesh Singh References: <20210325154713.670104-1-anthony.perard@citrix.com> <20210325154713.670104-5-anthony.perard@citrix.com> <90eb3caa-2116-e665-7dde-3fc7198409f2@amd.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 7 Apr 2021 10:01:21 +0200 MIME-Version: 1.0 In-Reply-To: <90eb3caa-2116-e665-7dde-3fc7198409f2@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/26/21 15:16, Lendacky, Thomas wrote: > On 3/25/21 10:47 AM, Anthony PERARD wrote: >> We are going to use the page table structure in yet another place, >> collect the types and macro that can be used from another module >> rather that making yet another copy. >> >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490 >> Signed-off-by: Anthony PERARD > > This begs the question of whether there should be only one version of this > header file, now. There are still copies in other places, but maybe that > can be a future cleanup? I'll leave that decision to Laszlo. Optimally the header file (a single header file) would exist solely in MdePkg, but I'm OK with this patch too. > > With one minor comment below, otherwise: > > Acked-by: Tom Lendacky > >> --- >> CC: Tom Lendacky >> CC: Brijesh Singh >> --- >> >> Notes: >> v2: >> - new patch >> >> .../IndustryStandard/PageTable.h} | 117 +------------- >> .../BaseMemEncryptSevLib/X64/VirtualMemory.h | 143 +----------------- >> 2 files changed, 5 insertions(+), 255 deletions(-) >> copy OvmfPkg/{Library/BaseMemEncryptSevLib/X64/VirtualMemory.h => Include/IndustryStandard/PageTable.h} (60%) >> > > ... > >> diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h >> index 996f94f07ebb..b621d811ca6f 100644 >> --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h >> +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.h >> @@ -20,151 +20,10 @@ >> #include >> #include >> #include >> +#include > > Typically, these are preferred to be in sorted order. Exactly, thanks. Laszlo > > Thanks, > Tom > >> >> #define SYS_CODE64_SEL 0x38 >> > > > > >