From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web10.10959.1573224201021260345 for ; Fri, 08 Nov 2019 06:43:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZI3eq2gW; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573224200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eYN47KlUX/DMsyt94ubHpBkFgis8FgMFZF8aP4aip4M=; b=ZI3eq2gWDdEVlXmtXkinI5nfzZvDSpnDkGNslj2B0BPxeeBSwz+SdM1+zaLFtTq3XQAuC3 nJRzTdYlI6u4n8NQzg7AxbTB7P+FJ0n5lh0GqmS/YU+/WRX1v9Wwov7iTQ83D8YOqAJQ1N vxnogZyi1L4499x+v6E2hSsR1ZWqnaU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-210-RlGTJx50Nee9sNJ6hlz1jw-1; Fri, 08 Nov 2019 09:43:17 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0D4948017DE; Fri, 8 Nov 2019 14:43:16 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-227.ams2.redhat.com [10.36.117.227]) by smtp.corp.redhat.com (Postfix) with ESMTP id AA11C1001B34; Fri, 8 Nov 2019 14:43:14 +0000 (UTC) Subject: Re: [edk2-devel] [Patch v4 17/22] UefiCpuPkg: Add YAML file for CI builds To: Sean Brogan , "Kinney, Michael D" , "devel@edk2.groups.io" Cc: "Dong, Eric" , "Ni, Ray" References: <20191107011349.16524-1-michael.d.kinney@intel.com> <20191107011349.16524-18-michael.d.kinney@intel.com> <6925ef4e-98dd-8634-1cbc-d177f1faa772@redhat.com> <4994e6f9-9a56-8be2-1167-41e56f5ff457@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 8 Nov 2019 15:43:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: RlGTJx50Nee9sNJ6hlz1jw-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/07/19 20:33, Sean Brogan wrote: > Laszlo, >=20 > Our legal team has requested that we don't include the copyright year.= =20 This sounds unusual, per https://en.wikipedia.org/wiki/Copyright_notice#Technical_requirements and also per https://edk2-docs.gitbooks.io/edk-ii-c-coding-standards-specification/5_so= urce_files/54_code_file_structure.html (note "Copyright (c) 20XX, Acme Corporation"). But, obviously, I'm not a lawyer, and your legal team consists of lawyers :) So if they prefer this format, my only remaining request is that this preference please be pointed out in the commit message: "the copyright notice(s) in the new file(s) do not contain a copyright year on purpose" The reason I'm asking for this is that "no copyright year" is unusual enough in edk2 that it deserves a comment ("it's not an oversight"). Thanks! Laszlo > -----Original Message----- > From: Kinney, Michael D =20 > Sent: Thursday, November 7, 2019 11:23 AM > To: devel@edk2.groups.io; lersek@redhat.com; Sean Brogan > Cc: Dong, Eric ; Ni, Ray > Subject: RE: [edk2-devel] [Patch v4 17/22] UefiCpuPkg: Add YAML file for= CI builds >=20 > Hi Laszlo, >=20 > I will let Sean comment on the copyright line contents. >=20 > Mike >=20 >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Laszlo= =20 >> Ersek >> Sent: Thursday, November 7, 2019 2:48 AM >> To: Kinney, Michael D ;=20 >> devel@edk2.groups.io >> Cc: Dong, Eric ; Ni, Ray >> Subject: Re: [edk2-devel] [Patch v4 17/22] UefiCpuPkg: >> Add YAML file for CI builds >> >> On 11/07/19 11:42, Laszlo Ersek wrote: >>> On 11/07/19 02:13, Michael D Kinney wrote: >>>> Add YAML file to the package directory with the >> configuration of the >>>> checks to perform during a CI build. >>>> >>>> Cc: Eric Dong >>>> Cc: Ray Ni >>>> Cc: Laszlo Ersek >>>> Signed-off-by: Michael D Kinney >> >>>> Acked-by: Laszlo Ersek >>>> --- >>>> UefiCpuPkg/UefiCpuPkg.ci.yaml | 51 >>>> +++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 51 insertions(+) >>>> create mode 100644 UefiCpuPkg/UefiCpuPkg.ci.yaml >>>> >>>> diff --git a/UefiCpuPkg/UefiCpuPkg.ci.yaml=20 >>>> b/UefiCpuPkg/UefiCpuPkg.ci.yaml new file mode 100644 >> index >>>> 0000000000..81da29b878 >>>> --- /dev/null >>>> +++ b/UefiCpuPkg/UefiCpuPkg.ci.yaml >>>> @@ -0,0 +1,51 @@ >>>> +## >>>> +# CI configuration for UefiCpuPkg >>>> +# >>>> +# Copyright (c) Microsoft Corporation # SPDX- >> License-Identifier: >>>> +BSD-2-Clause-Patent ## { >>>> + "CompilerPlugin": { >>>> + "DscPath": "UefiCpuPkg.dsc" >>>> + }, >>>> + "CharEncodingCheck": { >>>> + "IgnoreFiles": [] >>>> + }, >>>> + "DependencyCheck": { >>>> + "AcceptableDependencies": [ >>>> + "MdePkg/MdePkg.dec", >>>> + "MdeModulePkg/MdeModulePkg.dec", >>>> + "UefiCpuPkg/UefiCpuPkg.dec" >>>> + ], >>>> + # For host based unit tests >>>> + "AcceptableDependencies- >> HOST_APPLICATION":[], >>>> + # For UEFI shell based apps >>>> + "AcceptableDependencies- >> UEFI_APPLICATION":[], >>>> + "IgnoreInf": [] >>>> + }, >>>> + "DscCompleteCheck": { >>>> + "DscPath": "UefiCpuPkg.dsc", >>>> + "IgnoreInf": [ >>>> + >> "UefiCpuPkg/ResetVector/FixupVtf/Vtf.inf", >>>> + "UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf" >>>> + ] >>>> + }, >>>> + "GuidCheck": { >>>> + "IgnoreGuidName": ["SecCore", >> "ResetVector"], # Expected duplication for=20 >> gEfiFirmwareVolumeTopFileGuid >>>> + "IgnoreGuidValue": [], >>>> + "IgnoreFoldersAndFiles": [], >>>> + "IgnoreDuplicates": [] >>>> + }, >>>> + "LibraryClassCheck": { >>>> + "IgnoreHeaderFile": [] >>>> + }, >>>> + >>>> + ## options defined ci/Plugin/SpellCheck >>>> + "SpellCheck": { >>>> + "AuditOnly": True, # Fails test >> but run in AuditOnly mode to collect log >>>> + "IgnoreFiles": [], # use gitignore >> syntax to ignore errors in matching files >>>> + "ExtendWords": [], # words to >> extend to the dictionary for this package >>>> + "IgnoreStandardPaths": [], # Standard >> Plugin defined paths that should be ignore >>>> + "AdditionalIncludePaths": [] # Additional >> paths to spell check (wildcards supported) >>>> + } >>>> +} >>>> >>> >>> This is a very nice patch: good commit message (subjet >> and body both), >>> and good file comment. >>> >>> One suggestion: I'd recommend adding "@file" to the >> comment block at >>> the top. >>> >>> With that: >>> >>> Acked-by: Laszlo Ersek >>> >>> (Of course, should "@file" confuse the YAML parser, >> then I won't >>> insist, and my ACK still applies.) >> >> Ah, another remark: I believe the copyright notice should state a=20 >> year. >> (Most likely "2019".) >> >> Thanks >> Laszlo >> >> >>=20 >=20