public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, kraxel@redhat.com
Cc: Liming Gao <gaoliming@byosoft.com.cn>,
	Oliver Steffen <osteffen@redhat.com>
Subject: Re: [edk2-devel] [PATCH v2 0/2] MdeModulePkg: 5-level paging fixes
Date: Fri, 26 Jan 2024 00:22:18 +0100	[thread overview]
Message-ID: <fe39a7f6-8d91-e34b-b273-eb0e7397fce6@redhat.com> (raw)
In-Reply-To: <20240125082057.309133-1-kraxel@redhat.com>

On 1/25/24 09:20, Gerd Hoffmann wrote:
> - rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable
> - relax 5-level paging assert
> 
> Gerd Hoffmann (2):
>   MdeModulePkg: rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable
>   MdeModulePkg/VirtualMemory: fix 5-level paging assert
> 
>  MdeModulePkg/MdeModulePkg.dec                    | 2 +-
>  MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf          | 2 +-
>  MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 6 ++++--
>  MdeModulePkg/MdeModulePkg.uni                    | 4 ++--
>  4 files changed, 8 insertions(+), 6 deletions(-)
> 

series
Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Feel free to keep the R-b if Ray suggests a different approach for the
PCD renaming (e.g., keeping the existing name, or replacing "PcdGetBool
(PcdUse5LevelPageTable)" with constant TRUE altogether)

Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114478): https://edk2.groups.io/g/devel/message/114478
Mute This Topic: https://groups.io/mt/103950405/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      parent reply	other threads:[~2024-01-25 23:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25  8:20 [edk2-devel] [PATCH v2 0/2] MdeModulePkg: 5-level paging fixes Gerd Hoffmann
2024-01-25  8:20 ` [edk2-devel] [PATCH v2 1/2] MdeModulePkg: rename PcdUse5LevelPageTable to PcdEnable5LevelPageTable Gerd Hoffmann
2024-01-25 12:01   ` Ni, Ray
2024-01-25 12:17     ` Gerd Hoffmann
2024-01-26  2:49       ` Zhiguang Liu
2024-01-26 13:19         ` Gerd Hoffmann
2024-01-25  8:20 ` [edk2-devel] [PATCH v2 2/2] MdeModulePkg/VirtualMemory: fix 5-level paging assert Gerd Hoffmann
2024-01-25 23:22 ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe39a7f6-8d91-e34b-b273-eb0e7397fce6@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox