From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 29 Apr 2019 06:10:45 -0700 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B82CC3082E51; Mon, 29 Apr 2019 13:10:43 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-31.rdu2.redhat.com [10.10.121.31]) by smtp.corp.redhat.com (Postfix) with ESMTP id C1D705D6A9; Mon, 29 Apr 2019 13:10:41 +0000 (UTC) Subject: Re: [edk2-devel] [Patch v3 0/3] Add package level include DSC/FDF in NetworkPkg To: devel@edk2.groups.io, liming.gao@intel.com References: <20190425123735.10960-1-liming.gao@intel.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 29 Apr 2019 15:10:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190425123735.10960-1-liming.gao@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Mon, 29 Apr 2019 13:10:44 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/25/19 14:37, Liming Gao wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1293 > BZ 1293 requests to move Network modules from MdeModulePkg to NetworkPkg. > To keep the backword compatiblity, Network package level include DSC/FDF > are introduced to be used in the platform DSC/FDF files. When Network > modules are moved from MdeModulePkg to NetworkPkg, Network package level > include DSC/FDF will be updated together. There is no impact on the platform > DSC/FDF file. > > This patch set is to introduce network package level include DSC/FDF files. > Bases on previous discussion and the existing usage case, build flag will be > used to enable/disable the network features. PCD control feature way can be > discussed later. And, to meet with the different usages, this patch set > introduces the separate DSC for Defines/Pcds/Libraries/Components (Patch 2) > , and also adds the package level combined DSC to include them all (Patch 3). > If platform wants to use the flexible way to enable Network feature, it can > use the separate DSCs. If the platform wants to directly enable Network > feature, it can use the combined package DSC file. > > This patch set is to update NetworkPkg only. If there is no objection on this > proposal, the following changes to platform DSC/FDF will be made and sent for > review. By default, the platform DSC/FDF will use the combined DSC/FDF file. > If the platform owner wants to use the flexible way to enable Network feature, > please reply this mail. Yes, I'd like both OvmfPkg and ArmVirtPkg platforms to use the standalone include files from patch #2. As I mentioned in my review of patch #2, the new flags should be appropriate replacements for OvmfPkg and ArmVirtPkg, out of the box, except for NETWORK_TLS_ENABLE. - For ArmVirt, we're going to address TLS_ENABLE separately (see ). - In OvmfPkg, we'll keep TLS_ENABLE, and set NETWORK_TLS_ENABLE to FALSE (see the explanation in my review). Thanks! Laszlo > Liming Gao (3): > NetworkPkg DSC: Add the required ARM library to pass ARM build > NetworkPkg: Add DSC/FDF include segment files to NetworkPkg. > NetworkPkg: Add package level include DSC file > > NetworkPkg/Network.dsc.inc | 30 +++++++++ > NetworkPkg/Network.fdf.inc | 56 ++++++++++++++++ > NetworkPkg/NetworkComponents.dsc.inc | 61 +++++++++++++++++ > NetworkPkg/NetworkDefines.dsc.inc | 126 +++++++++++++++++++++++++++++++++++ > NetworkPkg/NetworkLibs.dsc.inc | 19 ++++++ > NetworkPkg/NetworkPcds.dsc.inc | 16 +++++ > NetworkPkg/NetworkPkg.dsc | 25 +------ > 7 files changed, 311 insertions(+), 22 deletions(-) > create mode 100644 NetworkPkg/Network.dsc.inc > create mode 100644 NetworkPkg/Network.fdf.inc > create mode 100644 NetworkPkg/NetworkComponents.dsc.inc > create mode 100644 NetworkPkg/NetworkDefines.dsc.inc > create mode 100644 NetworkPkg/NetworkLibs.dsc.inc > create mode 100644 NetworkPkg/NetworkPcds.dsc.inc >