From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=helo; client-ip=104.47.42.50; helo=nam03-by2-obe.outbound.protection.outlook.com; envelope-from=brijesh.singh@amd.com; receiver=edk2-devel@lists.01.org Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0050.outbound.protection.outlook.com [104.47.42.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4CC37223972C1 for ; Tue, 6 Feb 2018 14:06:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=elSNJRoRw0vlanPpyHkveDp8mEmGdhL/E1nfgX/1X54=; b=XrcIKFAo5VwSXD72ltfkSHnH89tN8bzIeUxxxxOWdazvrZIt1r55hlAKbPNxIKsRgOWr66uhLGwxva9/kFmS2/DQvhpoN0i/71mrHZ7WIww8+2ngqUAWzij+vqqTT+duTmw8+ZOavu9YV58nA43mmOu96qXRLfKsdypkmG8LI5c= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Received: from [10.236.136.62] (165.204.77.1) by SN1PR12MB0158.namprd12.prod.outlook.com (10.162.3.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Tue, 6 Feb 2018 22:12:01 +0000 Cc: brijesh.singh@amd.com, Ard Biesheuvel , Jordan Justen To: Laszlo Ersek , edk2-devel-01 References: <20180206220115.29193-1-lersek@redhat.com> <20180206220115.29193-3-lersek@redhat.com> From: Brijesh Singh Message-ID: Date: Tue, 6 Feb 2018 16:11:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180206220115.29193-3-lersek@redhat.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR18CA0028.namprd18.prod.outlook.com (10.175.9.142) To SN1PR12MB0158.namprd12.prod.outlook.com (10.162.3.145) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: dc9dd1ba-a987-4a31-e1c2-08d56daea647 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:SN1PR12MB0158; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 3:rozHXTupfLmAKAo7dVeLS2h4tAEw5LY8XcETZhVxTxQ9G02eCIyUbeAgHaPE3y7hNdbCL0SM0RHItZ7QYGUSCoX52aC6Ypf+/jHOleqaAeXBhEIZy32nqLEmMcEFEszyIdE9EPNNj3yD9WFq/GnkmC6bE9m6ZDg/JGG4fw8ETEm559PndaO/0KH9OVdv/TxMiGPbZd6LbEZdiq2fdGsxzoiHcfZWTq6eCMedNCym/QNfnyahJSkEftHyERZXj2WN; 25:bDD/V42NK9TuUBwjVGs31o7u7/boWh7bAMFAkk6eHrdasipaVE67jn3gWZ1buYaVEcE8+pqxXysPMYLm3pEM5Plkd2TD3OJ8Jn4EJwa/LTmfP7kcOKDdHdrXNmM/CFgKjEhPvv1DRh1AnNkso6mcUxrchTAuptjd6xN9M5TkRlNadwqHbVOOdk8ZDkOMLevSbm3hkwhG4E1Bp7b9vJkzsbUzK1dVPyoBRPRcHtIz8B2vq+IzxZk4SDWgrsGuFmKy1LxpnjUBXMV1HVQb3LdNP5KJJGoYCPxyaqF2XNbB2J8ZpKQ9G/KJq2C/0Y66od4d0/4QoPGE4eMy99AFd2EiRQ==; 31:vYg1w9bPMLEiIjo7KKBkoNrjTYdw7HpBRvX/V2Ok9fcXRMAjwyNiv6hIunqz5AG8Z+nYSro6OBpBefU8osIJrFWAQ3rm9O4J+06M5vIrwCyV//ZP8k9I6U35p9GaD2vbI9Umi/SNWiLhyzIvrwjP+loOLRmXMVDBynfq1Rl35jlppkjOqAWIDXWStxF6D5IABKwcZ+1UFUcvxe0BqvgbOibNlcKdKeF7LSOMHJ9Xw90= X-MS-TrafficTypeDiagnostic: SN1PR12MB0158: X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 20:Cqa+5uxaOM2U7zCd2axBjco2OSHx8EM4bj/W3mjVVPGVTkSkFjx3/GnwyTeza6Kc2tWBY4NTpH4VZkFjaBl3xz52bFr00jEMjck6GyOccDV4VXaIyN7WRGdWm7BgGgT1sRol+U8q+TzL3QwColD3ZrwUn8v691jFASbXtgDXPGuGiysoip6SybMFvU3OTEMWTKVHDpPFhZBt7t5I1LZdTQEEijxp0QZcr/Cl5Bsn3kORQrymC5II3oIFkGyf9cSD+O6Dw6UxQ7gtJUbHvEjVfK30tbLPtYcYPvlZNJoeYnEnB+Plvzx1twyg4aqKjGdQp0taxLQMjSZ3QOCj43YGQXr3/YSMekA0D1d3ICv+Zrcg0/0llgB1G2ODiGgzITa6IzGdIWoqXmqIOagPkKW5VnJf8v2+shb4Jt9P5ZEJkpD0Qxe1h/zx4hR+35MeD6KFgUObt3Bb+ak/u1Nicmk/DRXJo0np6o4ia/9G5bDQDwkHpFJ3aRF+6umDF62w1RAR; 4:AeOq8dvxIeX0dz2vakoeeL3mHFkNoQgKRJZbZMvZAWaEfIWqteT/Alqa0hLvi4pAMCd0y/vPLmhLKn3F4Ah6+PsMeBbaCd5bxBvEzGN7ULgX3VAJOS0BoZ9L+L1mjvDTeHqx75T9CEI409z4HEzXPNQs4twOQJkFz1alQ5vyIca+tX20N+rL6Lr7WBqWaRYccaIxpEr3mnGxYhxkLZs0904QtucymU+PZTxTwWq1haEWQAneERChYPwd91xvurM0d2xhXVxRyxNKShNxwYXPVwHfavrwXX/s+TwUute+fvLafSkC2HKmx/l+wzIkuSn3cGrI88JHaKTRM2gSX+8rxA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3231101)(2400082)(944501161)(3002001)(93006095)(93001095)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:SN1PR12MB0158; BCL:0; PCL:0; RULEID:; SRVR:SN1PR12MB0158; X-Forefront-PRVS: 0575F81B58 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(39850400004)(366004)(39380400002)(396003)(346002)(376002)(199004)(189003)(377424004)(97736004)(386003)(36756003)(3846002)(4326008)(81156014)(81166006)(8676002)(16576012)(90366009)(7736002)(230700001)(316002)(305945005)(54906003)(110136005)(58126008)(25786009)(6486002)(229853002)(64126003)(68736007)(31686004)(83506002)(6116002)(106356001)(67846002)(6246003)(478600001)(53546011)(53936002)(50466002)(5660300001)(2486003)(575784001)(86362001)(52146003)(23676004)(16526019)(65826007)(52116002)(31696002)(2906002)(47776003)(8936002)(59450400001)(186003)(65956001)(2950100002)(105586002)(66066001)(65806001)(77096007)(26005)(76176011)(6666003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB0158; H:[10.236.136.62]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU4OzIzOjI4KytHdTFzUkZIdTVNdzdRMmxyaEs0SFhM?= =?utf-8?B?TE1QSlZoUjNjaE1Pdy8zRjVGRnRldnNVbXZsSmJPd01wb2k5TmUxM3lzYVBx?= =?utf-8?B?NEwzYUo5S082eWlXemFQSzYrTTRCV2tuQm15SFpQaWNVNXNrdE9INWI0WDVF?= =?utf-8?B?ZTFaYUljbGltazNUVU1EL2NHdWVVVnNUSzN0U2R5cUJ6NzZQMmNuM2hQdGo5?= =?utf-8?B?NnZiLzZQZUV3eDRVTE5hbUYzMHB5MVY1RU5mSlFXbW1SbXRDV0ZnYjhwbEFo?= =?utf-8?B?YzJXVzJtTDEyYTlrRjBMaW1CdGhuKzRwK3pHN1Rkak1XdWZXU1FOYWNQd21a?= =?utf-8?B?VzVYM0JTZjhwcW9BV0tGV1VKUnkzbXErRVRFQTBEcVBQQytnODF6UkNOVnI1?= =?utf-8?B?Ri8wVFBOeDU4MTJCUXd5VW4yTTNFZ2hjakp4ZG5wZWlnb0dlNjdLUjl5aHo3?= =?utf-8?B?VjBYYjJxTHRrakhoaVBpa2c5NzJwOUYwZ25wY0dIKzNaYXVYa3VDYWRHNEpt?= =?utf-8?B?dDIzb3dxNlpGUkJWYjVFSHA1WXhPcWlmM0g5NjZKU3VvM2IrR1ZVYVA3eng3?= =?utf-8?B?S0dHdWZ1R3hjNXpWS2NUQ3BKcGxISnFwOVhuekxKOFc3Qk5LbEtJZzllWUtx?= =?utf-8?B?Qi9BZGVoWG9iM2xLME9iWnljY1FrYkdJc1RDK0s2NlN3QjJpZnJtRWY1WHAz?= =?utf-8?B?RDE0QXdWZ3lwS1BPN3N6YWp2Z2RHekgvZDY3YS9PMGZsaTdsQXltbEs3eCtv?= =?utf-8?B?Mmg4NnE0ZXNkZXA4K3pBUEhpamUrUXQrNkpKZFlHVHg3LzRDKyttZGxBYWIw?= =?utf-8?B?STlsTXlpODFqendzR1ZUOHBlbmZsVjBmU2tmbHJYUFRpTkxIcVdGNi9kY1F0?= =?utf-8?B?VWl3Qlc0dk5CVm9ZNkw0cXZaeE43Q1BQNG9WQWhyU0hUM0VaZmhyWkVqd1pH?= =?utf-8?B?MkJMaHJRREhLSTQwRE9RbDhMVXdYalBrMDdFbUNjRjZMVTJ5YzhJeEx6NENh?= =?utf-8?B?SUxzdmgyMG9LMXd2NGp2Ry8zTDAycktNRzRGVllvMFhsRFFWVWNjMWN0UHNZ?= =?utf-8?B?Y0Z1SkhEQ3cyNWkyNkdSa0pVRktPeXpXdTlOYjA4cE1hNmdxL0YzZklvc0lD?= =?utf-8?B?Z1dyZ1NXbFE2OTYxQllWWXRibHF2dlI0OVgxMFRzcGE4WXNUT1k5RGxpTDd1?= =?utf-8?B?c2wrUGY0Y0dkdHRHK1UxMi8rclBWdHlQSzF3M1J4YU5RMHQ3SFUxTkJzdUY4?= =?utf-8?B?aDlBUEJYeEp0dmlabGFnWitXcDhCcTFtYXRBdDIwNGw5MFVQanNwQ0dGOEpB?= =?utf-8?B?eHgrRFlpWFZZVENLYnZUN0pTYlVhbi9YRUNXQmxKaVNqNzdaYThqc2p1OTFP?= =?utf-8?B?cUtVSkpVYnZJT0laNWJ5ejNubDFZZERyT2t4Z1VGSlUrc1ozR2IvRWROd3ZZ?= =?utf-8?B?UXFSd2l1VTVjL2lOUVpZTW9GeGNIN0JNL0FJWnFEait2eGJ5TkhLUUdWd2p6?= =?utf-8?B?dmxpb0pwVFFvMkFVZFZlbDlNWFl1OUNCd0lDRnF3RjJKMUxYbitmUzhGbVFI?= =?utf-8?B?R0R5ZW5LS09GSTRUSUZOWVI4bzhtZzcwOHJuVDdBdy9FdzRqZmRkQnJXWXJ6?= =?utf-8?B?UGlOWjFSZW9ONEpiM3BmZVhKNUU3dUxHSkJQSHp1cldMRlh3UzVjcUhkRmRJ?= =?utf-8?B?QytKYjNpcHkrM0xXS29GM0VYSUFqam80dVEzOWVmaTRhMGxDdzhLcm82YmVR?= =?utf-8?B?QStodStrdzNpek5TQ1pDVm5jTEpPMlRwMjI0NWVZMGtxRDdTOTJkYm5Sbi9B?= =?utf-8?B?VkRpbE1BNkFCd2dDN3psWGUxWm1Lci9POFp4aWpOaWREaUZrSjZmQmhMM0hz?= =?utf-8?B?NHpsYXA0dzBPVDZCTWI2Yy9Ga2hYWStwTi80dmpKbExoVjFldFJVS3VBTHdO?= =?utf-8?B?S0hjMG56MjdXU1lxTU56SUV5aFRSVU1iQzVLYkN2WCtkemZEVk5LK25SbGhV?= =?utf-8?B?UytPZFBJTGRjRmlyclY2ZXdldWpWb25DK1F3WEZFSDlHODZjYzVIYnhNdFl5?= =?utf-8?Q?glas=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 6:mOZGtAUP5C6hSGHAtvTHNaGurfqdOxIAB6xzc2/GpIiwFaCilswDvda9jv0Ztd0OQo6D/pCw1QXnVYOTMZnsP1EZY5OfpwkkXMKxKDVGeVAn1zbLl5GaxuVSxwBwHm0oyloztP6nVt3rDTiG4wqX7xPPLmU/jC/SUtl7c/8si2plx26naUZ8zK8T3cUugncj6C0jcPYPVAKcBzJIZHEnyZ5KbyHqArut08PuFSPinvwJw6BQ51onu0EAguRFdqPLDo6+/3XPsUwsJ/dvtzfCg/i6aDxXBVM09pwBCQxqYT8aAAe+FsitZOGWJPNJXPAPbjzdOznobAOaTqUnrHQEOtaoUw2jY5/m3YP5YhkZGvs=; 5:wBPKTxZ90GPawBkOYS7RwXvvfdm8cYF4WIc11kn/Q0YFMJlklrCtmhJLwhxgyvvhSnWSonlPUqxrg2clGHaLRFWkJmkf21hjKKPiEVymUZUtXKDCfSedae3g1LNBYGP/HT0KqoA3TwcTaxtha33JAynSEILzwewWqrcHjY8tJUw=; 24:msuko8LhCFkeVV4dTzBWyFg1ul+XUjlNjakxZXnJsJkc5CyzzMkqnB+B4b8nlmCGCwKhzHVHi8zE6U9s9MZYZW31NN20FxPXFaR+7n0dLgA=; 7:4hwq+mytLsVFOE8tKUa+oFMzqb0VGoD/gNbvjxHXY3w8PY8pgSThVNGvj2oJbdfsecqFJRW6oQLfHm/W7iU3o2yGR2KfUwWVoPiZkYubGPBbNEqMoSUZeYQJhtZsdORRYW0GRGAzsJIeF3Bm5K8v2For9cCGyY1mliIYwkYuEwbyNIrBsv2km7rixdDBqxRMv05Ewua33nPa2rZ836Q8hKO4Ft+hP7/z14qeDzWWqfDYAZWfoXFTsLrhIeCe0JbB SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 20:zGqGmVqgYtKzrGK/FTuEqDxMPtSrkbH7PL82zyz4TuRCYN1o4mFWwvZzQPF5lXa7Hs7Tj+KeS1bt0ipdovG4yM3ns+Vetbk2tVDEVuoYOTGNE9LPuBOfFhmYobKcAjEvRD5Qj5z758pwk1YVYvUCTTrB4W8DSezGPlM5i1ZJLzBU44PKOG51nT1eK0hBvTIdSdCRWP0SRv6P0N+DDLQ//tqL72kU5ZF+KyCZ28CtFjJTB3B4TWFFGlmab9uP3Lmk X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2018 22:12:01.2071 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc9dd1ba-a987-4a31-e1c2-08d56daea647 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0158 Subject: Re: [PATCH 2/2] OvmfPkg/PlatformPei: sync AmdSevInitialize() definition with declaration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 22:06:22 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/06/2018 04:01 PM, Laszlo Ersek wrote: > "Platform.h" declares the AmdSevInitialize() function without EFIAPI, but > the definition in "AmdSev.c" includes EFIAPI. > > GCC toolchains without LTO do not catch this error because "AmdSev.c" does > not include "Platform.h"; i.e. the declaration used by callers such as > "Platform.c" is not actually matched against the function definition at > build time. > > With LTO enabled, the mismatch is found -- however, as a warning only, due > to commit f8d0b9662993 ("BaseTools GCC5: disable warnings-as-errors for > now", 2016-08-03). > > Include the header in the C file (which turns the issue into a hard build > error on all GCC toolchains), plus sync the declaration from the header > file to the C file. > > There's been no functional breakage because AmdSevInitialize() takes no > parameters. > > Cc: Ard Biesheuvel > Cc: Brijesh Singh > Cc: Jordan Justen > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek Reviewed-by: Brijesh Singh Thanks