public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel@lists.01.org, leif.lindholm@linaro.org
Subject: Re: [PATCH edk2-platforms] Silicon/SynQuacerPciHostBridgeLib: fix weird indentation
Date: Wed, 29 Nov 2017 20:24:11 +0100	[thread overview]
Message-ID: <fea53fb7-7a37-564b-3e15-6e5148c53ee7@redhat.com> (raw)
In-Reply-To: <20171129183505.7954-1-ard.biesheuvel@linaro.org>

Hi Ard,

On 11/29/17 19:35, Ard Biesheuvel wrote:
> Fix the weird indentation in the various #defines in the file containing
> the RC init code. This is a whitespace only change.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  Silicon/Socionext/SynQuacer/Library/SynQuacerPciHostBridgeLib/SynQuacerPciHostBridgeLibConstructor.c | 138 ++++++++++----------
>  1 file changed, 69 insertions(+), 69 deletions(-)

I'm not really supposed to comment on this, but the pre-patch
indentation is "native" to edk2. See for example

  MdePkg/Include/IndustryStandard/Pci22.h

I also follwed it in

  OvmfPkg/Include/IndustryStandard/Q35MchIch9.h
  OvmfPkg/Include/IndustryStandard/I440FxPiix4.h

Thanks
Laszlo


  parent reply	other threads:[~2017-11-29 19:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 18:35 [PATCH edk2-platforms] Silicon/SynQuacerPciHostBridgeLib: fix weird indentation Ard Biesheuvel
2017-11-29 19:14 ` Leif Lindholm
2017-11-29 19:24 ` Laszlo Ersek [this message]
2017-11-30 18:48   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fea53fb7-7a37-564b-3e15-6e5148c53ee7@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox