From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.757.1637719300037662577 for ; Tue, 23 Nov 2021 18:01:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=kbkGaiHd; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [10.0.0.19] (c-73-27-179-174.hsd1.fl.comcast.net [73.27.179.174]) by linux.microsoft.com (Postfix) with ESMTPSA id BAC6B20D4D3F; Tue, 23 Nov 2021 18:01:38 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BAC6B20D4D3F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1637719299; bh=yQ2TgnE9WRwCx684qdyp+ajz5jJ23VvoSXJgHH5x3y0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kbkGaiHdjy0sG947dcPwpcyYCrdBbS0rctK8WRIr/37NQvJen0YggQXMnffLHIJIZ Thi1uI3wMCfaFfBpsaswSj+Z3l1LZWxObQn8vUf4u1BDbBd9yANwlR8aB8zQmerSKG Bc0cs177TJdzsh1kdG373/p0iqBiyevFCX9bQPZc= Message-ID: Date: Tue, 23 Nov 2021 21:01:38 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [edk2-devel] [Patch 1/1] .azurepipelines/templates: Update max pipeline job time to 2 hours To: "Kinney, Michael D" , "devel@edk2.groups.io" Cc: Sean Brogan , Bret Barkelew , Liming Gao , Michael Kubacki References: <20211124004444.1938-1-michael.d.kinney@intel.com> <6e4ea875-d176-d30e-6eb7-acaace271312@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I wouldn't expect it to extend past 1 hour that often either. An occasional audit sounds good though. Do you think a BZ could be filed to track the ECC optimization work? I didn't see anything obvious with a quick search. Thanks, Michael On 11/23/2021 7:54 PM, Kinney, Michael D wrote: > Hi Michael, > > I would like to see some optimization work applied to the ECC tool to see if > we can reduce the time that tool requires. If we find some easy improvements > that allow larger patch series to complete in 60 minutes, then I am in favor > of reducing back down to 60 minutes. > > Unless we actually see jobs running more than 60 minutes or hitting the 120 > minute timeout, I do not see this patch causing problems. We can do an audit > of PRs once is a while to see what the job execution times are. > > If we do want to reduce, it will have to be a separate patch after uncrustify > set of PRs is applied. > > Mike > >> -----Original Message----- >> From: Michael Kubacki >> Sent: Tuesday, November 23, 2021 4:49 PM >> To: devel@edk2.groups.io; Kinney, Michael D >> Cc: Sean Brogan ; Bret Barkelew ; Liming Gao >> ; Michael Kubacki >> Subject: Re: [edk2-devel] [Patch 1/1] .azurepipelines/templates: Update max pipeline job time to 2 hours >> >> Hi Mike, >> >> Is the plan to keep it at a 2 hour limit indefinitely (not just for >> these large series currently outstanding)? >> >> Thanks, >> Michael >> >> On 11/23/2021 7:44 PM, Michael D Kinney wrote: >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3750 >>> >>> Large patches that modify a large number of files(e.g uncrustify) >>> take longer to process through CI checks such as ECC. Increase >>> the max job time from 1 hour to 2 hours to accommodate larger patch >>> series. >>> >>> Cc: Sean Brogan >>> Cc: Bret Barkelew >>> Cc: Liming Gao >>> Cc: Michael Kubacki >>> Signed-off-by: Michael D Kinney >>> --- >>> .azurepipelines/templates/pr-gate-build-job.yml | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml >>> index d5b16c127f58..244cffdbfaba 100644 >>> --- a/.azurepipelines/templates/pr-gate-build-job.yml >>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml >>> @@ -17,7 +17,7 @@ parameters: >>> jobs: >>> >>> - job: Build_${{ parameters.tool_chain_tag }} >>> - >>> + timeoutInMinutes: 120 >>> #Use matrix to speed up the build process >>> strategy: >>> matrix: >>>