public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 1/1] Adding the MAC in the HTTP Boot Title
       [not found] <cover.1607495687.git.sivaramann@ami.com>
@ 2020-12-09 16:20 ` INDIA\sivaramann
  2020-12-14 11:29   ` [edk2-devel] " Maciej Rabeda
  0 siblings, 1 reply; 2+ messages in thread
From: INDIA\sivaramann @ 2020-12-09 16:20 UTC (permalink / raw)
  To: devel

---
 NetworkPkg/HttpBootDxe/HttpBootConfig.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.c b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
index 646c907b12..677d913a09 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootConfig.c
+++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
@@ -629,6 +629,18 @@ HttpBootConfigFormInit (
       NULL
       );
 
+    OldMenuString = HiiGetString (
+                          CallbackInfo->RegisteredHandle, 
+                          STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE), 
+                          NULL
+                          );
+        UnicodeSPrint (MenuString, 128, L"MAC:%s-%s", MacString,OldMenuString);      
+        HiiSetString (
+          CallbackInfo->RegisteredHandle, 
+          STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE), 
+          MenuString, 
+          NULL
+          );
     FreePool (MacString);
     FreePool (OldMenuString);
 
-- 
2.28.0.windows.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [edk2-devel] [PATCH 1/1] Adding the MAC in the HTTP Boot Title
  2020-12-09 16:20 ` [PATCH 1/1] Adding the MAC in the HTTP Boot Title INDIA\sivaramann
@ 2020-12-14 11:29   ` Maciej Rabeda
  0 siblings, 0 replies; 2+ messages in thread
From: Maciej Rabeda @ 2020-12-14 11:29 UTC (permalink / raw)
  To: devel, emergingsiva

Nainar,

This is not the first time you are contributing a patch, yet you fail to 
do it in accordance to the process.
I cannot see *at minimum*: commit message, proper CC tags, bugzilla 
reference.

Please follow the process to have your patches reviewed.

Thanks,
Maciej

On 09-Dec-20 17:20, INDIA\sivaramann wrote:
> ---
>   NetworkPkg/HttpBootDxe/HttpBootConfig.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.c b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
> index 646c907b12..677d913a09 100644
> --- a/NetworkPkg/HttpBootDxe/HttpBootConfig.c
> +++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.c
> @@ -629,6 +629,18 @@ HttpBootConfigFormInit (
>         NULL
>
>         );
>
>   
>
> +    OldMenuString = HiiGetString (
>
> +                          CallbackInfo->RegisteredHandle,
>
> +                          STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE),
>
> +                          NULL
>
> +                          );
>
> +        UnicodeSPrint (MenuString, 128, L"MAC:%s-%s", MacString,OldMenuString);
>
> +        HiiSetString (
>
> +          CallbackInfo->RegisteredHandle,
>
> +          STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE),
>
> +          MenuString,
>
> +          NULL
>
> +          );
>
>       FreePool (MacString);
>
>       FreePool (OldMenuString);
>
>   
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-14 11:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <cover.1607495687.git.sivaramann@ami.com>
2020-12-09 16:20 ` [PATCH 1/1] Adding the MAC in the HTTP Boot Title INDIA\sivaramann
2020-12-14 11:29   ` [edk2-devel] " Maciej Rabeda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox