From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.33581.1607945399853898437 for ; Mon, 14 Dec 2020 03:29:59 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 192.55.52.93, mailfrom: maciej.rabeda@linux.intel.com) IronPort-SDR: iELAja0PlYXUUTxxb66gPL0ElF2rjQGH6XZbDGeA2hIZM/XuuIH5Y0IgaVRfmugReLURKqsSXi PeuFMOJKrjkQ== X-IronPort-AV: E=McAfee;i="6000,8403,9834"; a="171181098" X-IronPort-AV: E=Sophos;i="5.78,418,1599548400"; d="scan'208";a="171181098" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 03:29:58 -0800 IronPort-SDR: y+npHUIjMnx+vmRNLp2XVxojD8qgxHXsFKBQYCnkeoAM1mHcgeDj2X6xRv7p3HPH+Gw7ORSD4U UndxIMG1dGCw== X-IronPort-AV: E=Sophos;i="5.78,418,1599548400"; d="scan'208";a="367332005" Received: from mrabeda-mobl.ger.corp.intel.com (HELO [10.252.55.43]) ([10.252.55.43]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 03:29:57 -0800 Subject: Re: [edk2-devel] [PATCH 1/1] Adding the MAC in the HTTP Boot Title To: devel@edk2.groups.io, emergingsiva@gmail.com References: From: "Maciej Rabeda" Message-ID: Date: Mon, 14 Dec 2020 12:29:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: pl Nainar, This is not the first time you are contributing a patch, yet you fail to do it in accordance to the process. I cannot see *at minimum*: commit message, proper CC tags, bugzilla reference. Please follow the process to have your patches reviewed. Thanks, Maciej On 09-Dec-20 17:20, INDIA\sivaramann wrote: > --- > NetworkPkg/HttpBootDxe/HttpBootConfig.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.c b/NetworkPkg/HttpBootDxe/HttpBootConfig.c > index 646c907b12..677d913a09 100644 > --- a/NetworkPkg/HttpBootDxe/HttpBootConfig.c > +++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.c > @@ -629,6 +629,18 @@ HttpBootConfigFormInit ( > NULL > > ); > > > > + OldMenuString = HiiGetString ( > > + CallbackInfo->RegisteredHandle, > > + STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE), > > + NULL > > + ); > > + UnicodeSPrint (MenuString, 128, L"MAC:%s-%s", MacString,OldMenuString); > > + HiiSetString ( > > + CallbackInfo->RegisteredHandle, > > + STRING_TOKEN (STR_HTTP_BOOT_CONFIG_FORM_TITLE), > > + MenuString, > > + NULL > > + ); > > FreePool (MacString); > > FreePool (OldMenuString); > > >