public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Tomas Pilar (tpilar)" <tpilar@solarflare.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: SNP_INIT while in TPL_NOTIFY
Date: Fri, 27 Jan 2017 16:51:12 +0000	[thread overview]
Message-ID: <feeb6335-76ee-efa5-8966-033a6d265ea9@solarflare.com> (raw)

Hi,

I am currently maintaining our network driver written using the EDKII
framework. Our network device implements a MCDI (mc-driver interface)
which is (in theory) asynchronous (DMA doorbell-messagebox
communication), although the majority of the calls take less than a
jiffy. So for example, the setting up of TX and RX queues on the NIC
requires some MCDI calls which the driver then has to wait for. I've
implemented this using the gSB->SetTimer event system.

My problem is that the SimpleNetworkInitialize() method is called by the
UEFI platform network core (network core finds a new NIC with SNP ->
tries to open -> not initialised, so it tries to INIT) using a
TPL_NOTIFY context, where the code is not allowed to sleep (I assume
that this is the MNP generic one second network poll timer). I could in
theory initialise the NIC earlier, during probe, but the SNP allows for
specification of extra buffer space for TX and RX during init. The
network core might conceivable use that. Or the MNP might want to change
station address using SNP or call for a reset which again requires
asynchronous NIC operation.

Has anyone encountered something similar? Is there a canonical solution
to this issue?

Cheers,
Tomas Pilar


The information contained in this message is confidential and is intended for the addressee(s) only. If you have received this message in error, please notify the sender immediately and delete the message. Unless you are an addressee (or authorized to receive for an addressee), you may not use, copy or disclose to anyone this message or any information contained in this message. The unauthorized use, disclosure, copying or alteration of this message is strictly prohibited.


             reply	other threads:[~2017-01-27 16:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27 16:51 Tomas Pilar (tpilar) [this message]
2017-01-27 18:12 ` SNP_INIT while in TPL_NOTIFY Laszlo Ersek
2017-01-30 10:51   ` Tomas Pilar (tpilar)
2017-01-30 17:51   ` Andrew Fish
2017-02-06  6:10   ` Ye, Ting
2017-02-06 14:58     ` Tomas Pilar (tpilar)
2017-02-07  3:31       ` Ye, Ting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=feeb6335-76ee-efa5-8966-033a6d265ea9@solarflare.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox