From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.13660.1686317991310394256 for ; Fri, 09 Jun 2023 06:39:51 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Q12sc8j0; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: kurugodumelmatamx.aishwarya@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686317991; x=1717853991; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Y0iTw9shkYTGuCt72gXMAhAEUsDOVZe8M7rCF/8ouig=; b=Q12sc8j0Jc2COznwpyEKhdITKeSmjDSizX6amiNyqbU3AajR5HOLPAse kPVbIY5CpKwOAy+zUle4uBh3iycDVuowaRFWU8mUvRMgUP4B7TUP7Sk0y VnoyN7WNIZ3IEdym/TrIur6Xj2zXyPIXGaOljoWGA19DebEOsnIYfOxL7 1DpSKLOW54x5Awmg7HeHxs8+gtmuZ+H1FKZA3tL8lf0NYmINgpqhuZ48S xyVyHuxiJZllhfzAdeu6JkJQt47cn16tbz3BBKe5WOZGFqArJFPbUrRoe sscV+itjXJmlWDjamcnUhIJFOegdzBzbP0+jeqCGi3NeQHfxyp2Ograj4 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10736"; a="342275232" X-IronPort-AV: E=Sophos;i="6.00,229,1681196400"; d="scan'208";a="342275232" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2023 06:39:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10736"; a="713519965" X-IronPort-AV: E=Sophos;i="6.00,229,1681196400"; d="scan'208";a="713519965" Received: from kurugodx-desk.gar.corp.intel.com ([10.66.234.59]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2023 06:39:47 -0700 From: kurugodx To: devel@edk2.groups.io Cc: kurugodx , Chasel Chiu , Nate DeSimone , Duggapu Chinni B , Chen Gang C , Star Zeng , Ted Kuo , Ashraf Ali S , Susovan Mohapatra Subject: [PATCH] Get HobListPtr before calling the Multiphase FSPS Date: Fri, 9 Jun 2023 06:39:41 -0700 Message-ID: X-Mailer: git-send-email 2.41.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4480 In the FspsWrapperPeim, before calling FspWrapperVariableRequestHandler and FspWrapperMultiPhaseHandler ,FspHobListPtr should be available so that BL will be able to get the correct FspHobListPtr value Signed-off-by: kurugodx Cc: Chasel Chiu Cc: Nate DeSimone Cc: Duggapu Chinni B Cc: Chen Gang C Cc: Star Zeng Cc: Ted Kuo Cc: Ashraf Ali S Cc: Susovan Mohapatra --- .../FspsWrapperPeim/FspsWrapperPeim.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c index 08fe0fdb7e..1d4dd60577 100644 --- a/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c +++ b/IntelFsp2WrapperPkg/FspsWrapperPeim/FspsWrapperPeim.c @@ -336,6 +336,14 @@ PeiMemoryDiscoveredNotify ( DEBUG ((DEBUG_INFO, "FspSiliconInit status: %r\n", Status)); + // + // Get FspHobList + // + GuidHob = GetFirstGuidHob (&gFspHobGuid); + ASSERT (GuidHob != NULL); + FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob); + DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr)); + if (Status == FSP_STATUS_VARIABLE_REQUEST) { // // call to Variable request handler @@ -356,13 +364,6 @@ PeiMemoryDiscoveredNotify ( DEBUG ((DEBUG_ERROR, "ERROR - TestFspSiliconInitApiOutput () fail, Status = %r\n", Status)); } - // - // Now FspHobList complete, process it - // - GuidHob = GetFirstGuidHob (&gFspHobGuid); - ASSERT (GuidHob != NULL); - FspHobListPtr = *(VOID **)GET_GUID_HOB_DATA (GuidHob); - DEBUG ((DEBUG_INFO, "FspHobListPtr - 0x%x\n", FspHobListPtr)); PostFspsHobProcess (FspHobListPtr); // -- 2.41.0.windows.1