Re: [edk2-devel] [PATCH 0/1] OvmfPkg/Bhyve: QemuFwCfg support

["Corvin Köhne" <c.koehne@beckhoff.com>]

Hi Gerd,

> There is FW_CFG_NB_CPUS + FW_CFG_MAX_CPUS.  ovmf uses different names,
> see OvmfPkg/Include/IndustryStandard/QemuFwCfg.h
>
> PlatformPei for qemu uses QemuFwCfgItemSmpCpuCount aka FW_CFG_NB_CPUS,
> which is the number of cpus which are online.
>
> I think FW_CFG_MAX_CPUS is basically unused these days.  It played a
> role back when seabios created the acpi tables for cpu hotplug as
> described in the comment above.  In qemu 2.0 & newer the acpi tables are
> generated by qemu instead.  The firmware just downloads them from fw_cfg
> and installs them for the OS, it doesn't need to know virtual machine
> configuration details any more.

The FwCfgItem of this patch is used by bhyve to build the MADT. So, it's
similar to the use case of FW_CFG_MAX_CPUS. At the moment, I'm using
an additional bhyve specific FwCfgItem. I just want to ask, if it makes sense
to use FW_CFG_MAX_CPUS to avoid two items for the same purpose or to
keep it as is.


Best regards
Corvin


Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff
Registered office: Verl, Germany | Register court: Guetersloh HRA 7075