From: "Dov Murik" <dovmurik@linux.ibm.com>
To: Laszlo Ersek <lersek@redhat.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jordan Justen <jordan.l.justen@intel.com>,
James Bottomley <jejb@linux.ibm.com>,
Tobin Feldman-Fitzthum <tobin@linux.ibm.com>,
Dov Murik <dovmurik@linux.ibm.com>
Subject: Re: [edk2-devel] [PATCH v2 3/3] OvmfPkg/X86QemuLoadImageLib: State fw_cfg dependency in file header
Date: Sun, 27 Jun 2021 11:59:54 +0300 [thread overview]
Message-ID: <ff4cf9fc-d5e1-36b4-5df6-1be2d2c47aa5@linux.ibm.com> (raw)
In-Reply-To: <327b534a-380c-44ce-ce4a-620a8d4463a2@redhat.com>
On 24/06/2021 20:53, Laszlo Ersek wrote:
> On 06/17/21 14:17, Dov Murik wrote:
>> Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the
>> ground to add a warning about the incompatibility with boot verification
>> process.
>>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: James Bottomley <jejb@linux.ibm.com>
>> Cc: Tobin Feldman-Fitzthum <tobin@linux.ibm.com>
>> Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
>> ---
>> OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf | 3 +++
>> OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 3 +++
>> 2 files changed, 6 insertions(+)
>
> (1) The bugzilla ticket should be referenced in the commit message,
> above your signoff:
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3457
>
I'll add it.
> With that update:
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
-Dov
prev parent reply other threads:[~2021-06-27 9:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 12:16 [RESEND] [PATCH v2 0/3] OvmfPkg: Use QemuKernelLoaderFs to read cmdline/initrd Dov Murik
2021-06-17 12:16 ` [PATCH v2 1/3] Revert "OvmfPkg/QemuKernelLoaderFsDxe: don't expose kernel command line" Dov Murik
2021-06-24 13:46 ` [edk2-devel] " Laszlo Ersek
2021-06-27 8:58 ` Dov Murik
2021-06-17 12:16 ` [PATCH v2 2/3] OvmfPkg/GenericQemuLoadImageLib: Read cmdline from QemuKernelLoaderFs Dov Murik
2021-06-24 17:49 ` [edk2-devel] " Laszlo Ersek
2021-06-27 9:05 ` Dov Murik
2021-06-17 12:17 ` [PATCH v2 3/3] OvmfPkg/X86QemuLoadImageLib: State fw_cfg dependency in file header Dov Murik
2021-06-24 17:53 ` [edk2-devel] " Laszlo Ersek
2021-06-27 8:59 ` Dov Murik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff4cf9fc-d5e1-36b4-5df6-1be2d2c47aa5@linux.ibm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox