From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web11.3099.1624784404223763753 for ; Sun, 27 Jun 2021 02:00:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=MklvxOk7; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: dovmurik@linux.ibm.com) Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15R8Y6vM018504; Sun, 27 Jun 2021 05:00:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=NNu1oJdnSCAzbwvUivPEQ448rTwXtBNrF4egRS2pMXc=; b=MklvxOk71tQ7SXLekVtrutlqlgcEOyusxxMeKUE6CVmJ3aNDRYskT97oRfVoqa8LWYpv OnTFIZ5qpVE5UQK/+XF7DQg9/A963gTXrAL7cUhCX7xHBRr9B1fLX7j15j3gn2i7R0HP gzn8ock1p2lzHcfGMmS1POf2VOaqS6+Z6clf1bzlABLBV/CUOHBmpKOWlm8Zx/n2d+8W uoNjz3gK5G9pXxyKpoXKvrq5A16aQXB49IgOUQCrMH0nggUVLDhA1vjhwsca33o1OqTT O2+d/NN33o1ijmmeEKJkzhZAn/M3kfy46IDMGEk5bgJBqkAI3KLTmMbvd3pf/ZqnLtdd zQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 39enpqggve-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 27 Jun 2021 05:00:03 -0400 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 15R8boCU028608; Sun, 27 Jun 2021 05:00:03 -0400 Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0b-001b2d01.pphosted.com with ESMTP id 39enpqggug-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 27 Jun 2021 05:00:02 -0400 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 15R8sS1V005777; Sun, 27 Jun 2021 09:00:01 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma05fra.de.ibm.com with ESMTP id 39duv8g63f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 27 Jun 2021 09:00:00 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 15R8xvC333554774 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 27 Jun 2021 08:59:57 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A862DA405C; Sun, 27 Jun 2021 08:59:57 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 82819A4054; Sun, 27 Jun 2021 08:59:55 +0000 (GMT) Received: from [9.160.49.135] (unknown [9.160.49.135]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Sun, 27 Jun 2021 08:59:55 +0000 (GMT) Subject: Re: [edk2-devel] [PATCH v2 3/3] OvmfPkg/X86QemuLoadImageLib: State fw_cfg dependency in file header To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen , James Bottomley , Tobin Feldman-Fitzthum , Dov Murik References: <20210617121700.2883073-1-dovmurik@linux.ibm.com> <20210617121700.2883073-4-dovmurik@linux.ibm.com> <327b534a-380c-44ce-ce4a-620a8d4463a2@redhat.com> From: "Dov Murik" Message-ID: Date: Sun, 27 Jun 2021 11:59:54 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <327b534a-380c-44ce-ce4a-620a8d4463a2@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: kuLJ_tOOhrNnhcfqYM-ct-4O9557YThA X-Proofpoint-ORIG-GUID: cyL9gHL0IN83Ab4cJkqgWQKO31UfbYuF X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-06-26_15:2021-06-25,2021-06-26 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 adultscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106270061 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 24/06/2021 20:53, Laszlo Ersek wrote: > On 06/17/21 14:17, Dov Murik wrote: >> Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the >> ground to add a warning about the incompatibility with boot verification >> process. >> >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Cc: James Bottomley >> Cc: Tobin Feldman-Fitzthum >> Signed-off-by: Dov Murik >> --- >> OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.inf | 3 +++ >> OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 3 +++ >> 2 files changed, 6 insertions(+) > > (1) The bugzilla ticket should be referenced in the commit message, > above your signoff: > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 > I'll add it. > With that update: > > Reviewed-by: Laszlo Ersek Thanks! -Dov