From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::72c; helo=mail-qk1-x72c.google.com; envelope-from=vladimir.olovyannikov@broadcom.com; receiver=edk2-devel@lists.01.org Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 466BE2112386F for ; Thu, 6 Sep 2018 11:56:02 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id 93-v6so8071266qks.3 for ; Thu, 06 Sep 2018 11:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9H9wjsWcL3F5OaQUFWfNmQ+oi6Qn14zZcGpSouyKTro=; b=RnVmOZhNoJx6xMSNnj7Joi+TAD9sDHGAtdev8f6xsEhK6QUwbIJnWV0zjD96ONEnHY CV4CctMH9n/av+qcyjTSKfdKbOReyQgTyv6dM+7KTRqxPDhd13bm6OlcDzSsEiX/QyiV u/JVCpgyilfCE1SgWVjuBRWUpKTYuOcDW+t1o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9H9wjsWcL3F5OaQUFWfNmQ+oi6Qn14zZcGpSouyKTro=; b=R76LZjO9Y5o0IWBLTsVm0ktTrYhGZRxxJaZfdJwtR9tsErKjJCRGD0hmwQIJt1zT7y D5kF3TUUep7B+/EHOhrA33xm13kHWj1FzdOezJ7mlvglS8QWdWHxO5dBd559kMcXRGHL d/0eEtxN+IwZMs7yNzzsrTzW4/Gswv0OUPum05twA/cl+J7+1K2E0CpYaHCoOe6GcIQr FCCuHv6L6j7WDdfGSm+dO+3w4mojJf3xRV/pWTedocd9i5ia+yeErkH25j9X+hPgRhpN e3QXHU2xcWU6VdRWHhwVoaJez4WKdlK4b4uPwX70apua1wWttMIUqobCxh2HZ7MlM+fQ bsPQ== X-Gm-Message-State: APzg51DG9zkI7JQ2CGMXTIataiUO2fmvjV295p7TcX62mKtQ9ibRZ2uH Amxg6E5kPGUoz5S+Cvd096aYVb8oorHYYQ== X-Google-Smtp-Source: ANB0Vdbk8m1jFWhzs+MV2AfcafZe6VVZoM8D4Bv8NpzuOLAaftDLZQytz9+AGMZJaqk9DiwkLIKCBw== X-Received: by 2002:a37:7347:: with SMTP id o68-v6mr3250779qkc.291.1536260160920; Thu, 06 Sep 2018 11:56:00 -0700 (PDT) Received: from LBRMN-LNXUB114.ric.broadcom.com ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id 187-v6sm3417010qki.19.2018.09.06.11.55.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 06 Sep 2018 11:56:00 -0700 (PDT) From: Vladimir Olovyannikov To: edk2-devel@lists.01.org, Ard Biesheuvel , Leif Lindholm , Ruiyu Ni Cc: Vladimir Olovyannikov Date: Thu, 6 Sep 2018 11:55:03 -0700 Message-Id: X-Mailer: git-send-email 2.18.0 In-Reply-To: References: Subject: [PATCH 2/3] EmbeddedPkg/CoherentDmaLib: Add missing checks to DmaMap X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Sep 2018 18:56:02 -0000 UEFI Sct validates Dma mapping. For CoherentDmaLib it always failed because there were no required checks present in DmaMap. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Vladimir Olovyannikov --- EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c b/EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c index 8ca9e6aa5b1b..eb88fa288a99 100644 --- a/EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c +++ b/EmbeddedPkg/Library/CoherentDmaLib/CoherentDmaLib.c @@ -58,6 +58,12 @@ DmaMap ( OUT VOID **Mapping ) { + if (HostAddress == NULL || + NumberOfBytes == NULL || + DeviceAddress == NULL || + Mapping == NULL ) { + return EFI_INVALID_PARAMETER; + } *DeviceAddress = HostToDeviceAddress (HostAddress); *Mapping = NULL; return EFI_SUCCESS; -- 2.18.0