public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Jeremy Linton <jeremy.linton@arm.com>
To: edk2-devel@lists.01.org
Cc: leif.lindholm@linaro.org, ryan.harkin@linaro.org,
	linaro-uefi@lists.linaro.org, ard.biesheuvel@linaro.org,
	Steve.Capper@arm.com
Subject: Re: [PATCH v2 0/7] ATAPI support on SiI SATA adapter
Date: Thu, 23 Feb 2017 16:36:13 -0600	[thread overview]
Message-ID: <ff4fd504-6079-37eb-67c9-5040e64f6b22@arm.com> (raw)
In-Reply-To: <20170223220405.1954-1-jeremy.linton@arm.com>

Hi,

Please ignore this patch set, and rather look at the V3 version. I had a 
stale set of patches in the directory I sent v2 from.

Sorry about the noise.

Thanks,



On 02/23/2017 04:03 PM, Jeremy Linton wrote:
> The SiI isn't an AHCI compatible adapter so it implements the EFI ATA
> pass-through protocol directly. This works for fixed hard drives, but
> not ATAPI attached devices (CDROM, DVDROM, TAPE, etc).
>
> This patch adds read only ATAPI support via the EFI SCSI pass-through
> protocol, allowing boot from attached CD/DVD. This patch also cleans
> up, and tweaks recovery paths/etc in the original driver. When
> combined with the ARM/PCI dma lib changes this allows us to relax the
> IO alignment requirement that caused grub failures.
>
> Finally, the OpenPlatformPkg/Juno must be updated, with another patch
> to avoid build breaks now that the SiI has a dependency on the SCSI
> libraries.
>
> V1->V2:
>   Formatting corrections per Ard's comments and Daniil's
>   updated patch checker.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
>
> Jeremy Linton (7):
>   EmbeddedPkg: SiI3132: Note that ARM is using this Dxe
>   MdePkg IndustryStandard/Scsi.h: Add sense code macro
>   EmbeddedPkg: SiI3132: Add ScsiProtocol callbacks
>   EmbeddedPkg: SiI3132: Add SCSI protocol support to header
>   EmbeddedPkg: SiI3132: Break out FIS command submission
>   EmbeddedPkg: SiI3132: Cleanup device node creation
>   EmbeddedPkg: SiI3132: Enable SCSI pass-through protocol
>
>  EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c   |  49 ++-
>  EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h   |  93 ++++-
>  .../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf      |   2 +
>  .../Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c    | 268 ++++++++-----
>  .../Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c   | 431 +++++++++++++++++++++
>  MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf       |   2 +-
>  MdePkg/Include/IndustryStandard/Scsi.h             |   2 +
>  OpenPlatformPkg                                    |   2 +-
>  8 files changed, 721 insertions(+), 128 deletions(-)
>  create mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c
>



      parent reply	other threads:[~2017-02-23 22:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23 22:03 [PATCH v2 0/7] ATAPI support on SiI SATA adapter Jeremy Linton
2017-02-23 22:03 ` [PATCH v2 1/7] EmbeddedPkg: SiI3132: Note that ARM is using this Dxe Jeremy Linton
2017-02-23 22:03 ` [PATCH v2 2/7] MdePkg IndustryStandard/Scsi.h: Add sense code macro Jeremy Linton
2017-02-23 22:04 ` [PATCH v2 3/7] EmbeddedPkg: SiI3132: Add ScsiProtocol callbacks Jeremy Linton
2017-02-23 22:04 ` [PATCH v2 4/7] EmbeddedPkg: SiI3132: Add SCSI protocol support to header Jeremy Linton
2017-02-23 22:04 ` [PATCH v2 5/7] EmbeddedPkg: SiI3132: Break out FIS command submission Jeremy Linton
2017-02-23 22:04 ` [PATCH v2 6/7] EmbeddedPkg: SiI3132: Cleanup device node creation Jeremy Linton
2017-02-23 22:04 ` [PATCH v2 7/7] EmbeddedPkg: SiI3132: Enable SCSI pass-through protocol Jeremy Linton
2017-02-23 22:04 ` [PATCH] Platforms/ARM/Juno: Add " Jeremy Linton
2017-02-23 22:36 ` Jeremy Linton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff4fd504-6079-37eb-67c9-5040e64f6b22@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox