From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 01FB482152 for ; Thu, 23 Feb 2017 14:36:15 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DE10428; Thu, 23 Feb 2017 14:36:14 -0800 (PST) Received: from [192.168.229.136] (u201426.usa.arm.com [10.118.28.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3858D3F483; Thu, 23 Feb 2017 14:36:14 -0800 (PST) To: edk2-devel@lists.01.org References: <20170223220405.1954-1-jeremy.linton@arm.com> Cc: leif.lindholm@linaro.org, ryan.harkin@linaro.org, linaro-uefi@lists.linaro.org, ard.biesheuvel@linaro.org, Steve.Capper@arm.com From: Jeremy Linton Message-ID: Date: Thu, 23 Feb 2017 16:36:13 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170223220405.1954-1-jeremy.linton@arm.com> Subject: Re: [PATCH v2 0/7] ATAPI support on SiI SATA adapter X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 22:36:15 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Hi, Please ignore this patch set, and rather look at the V3 version. I had a stale set of patches in the directory I sent v2 from. Sorry about the noise. Thanks, On 02/23/2017 04:03 PM, Jeremy Linton wrote: > The SiI isn't an AHCI compatible adapter so it implements the EFI ATA > pass-through protocol directly. This works for fixed hard drives, but > not ATAPI attached devices (CDROM, DVDROM, TAPE, etc). > > This patch adds read only ATAPI support via the EFI SCSI pass-through > protocol, allowing boot from attached CD/DVD. This patch also cleans > up, and tweaks recovery paths/etc in the original driver. When > combined with the ARM/PCI dma lib changes this allows us to relax the > IO alignment requirement that caused grub failures. > > Finally, the OpenPlatformPkg/Juno must be updated, with another patch > to avoid build breaks now that the SiI has a dependency on the SCSI > libraries. > > V1->V2: > Formatting corrections per Ard's comments and Daniil's > updated patch checker. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeremy Linton > > Jeremy Linton (7): > EmbeddedPkg: SiI3132: Note that ARM is using this Dxe > MdePkg IndustryStandard/Scsi.h: Add sense code macro > EmbeddedPkg: SiI3132: Add ScsiProtocol callbacks > EmbeddedPkg: SiI3132: Add SCSI protocol support to header > EmbeddedPkg: SiI3132: Break out FIS command submission > EmbeddedPkg: SiI3132: Cleanup device node creation > EmbeddedPkg: SiI3132: Enable SCSI pass-through protocol > > EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 49 ++- > EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h | 93 ++++- > .../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf | 2 + > .../Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 268 ++++++++----- > .../Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c | 431 +++++++++++++++++++++ > MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 2 +- > MdePkg/Include/IndustryStandard/Scsi.h | 2 + > OpenPlatformPkg | 2 +- > 8 files changed, 721 insertions(+), 128 deletions(-) > create mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c >