From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 30 Sep 2019 16:12:20 -0700 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8387059465; Mon, 30 Sep 2019 23:12:20 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-111.rdu2.redhat.com [10.10.121.111]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63F935D9C9; Mon, 30 Sep 2019 23:12:19 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0 To: devel@edk2.groups.io, ray.ni@intel.com, "pete@akeo.ie" Cc: "Gao, Zhichao" References: <20190925155005.12532-1-pete@akeo.ie> <734D49CCEBEEF84792F5B80ED585239D5C30A314@SHSMSX104.ccr.corp.intel.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 1 Oct 2019 01:12:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C30A314@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 30 Sep 2019 23:12:20 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/30/19 03:24, Ni, Ray wrote: > Existing close source platform BDS only updates UI in this function. > Reviewed-by: Ray Ni Thanks, Ray! Can you please push this patch for Pete? Thanks Laszlo > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Pete Batard >> Sent: Wednesday, September 25, 2019 11:50 PM >> To: devel@edk2.groups.io >> Cc: Gao, Zhichao ; Ni, Ray >> Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0 >> >> The existing loop is set to call PlatformBootManagerWaitCallback every >> second except the last one. We believe this is a mistake as it prevents >> the called code from performing timeout expiration tasks such as, for >> instance, ensuring that the last segment of a progress bar is displayed >> before continuing (which is a current issue for the RPi3 platform). >> >> Signed-off-by: Pete Batard >> --- >> MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c >> index f3d5e5ac0615..7968a58f3454 100644 >> --- a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c >> +++ b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c >> @@ -341,6 +341,7 @@ BdsWait ( >> TimeoutRemain--; >> } >> } >> + PlatformBootManagerWaitCallback (0); >> DEBUG ((EFI_D_INFO, "[Bds]Exit the waiting!\n")); >> } >> >> -- >> 2.21.0.windows.1 >> >> >> > > > >