From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web09.25294.1574349751011038425 for ; Thu, 21 Nov 2019 07:22:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Dv5setKH; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574349750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zxxR9ZmBS3GSvH6q1mm81wM6ldotur7e3yQXRzTQOJ8=; b=Dv5setKHQ0C8xUgHfQZ+GBsi1ndpVxJAfZQtS41QvOgzyX5rj+dXalKa6H+UHasokswUJC T9xqVLrnRcVGKPqOQu6KxPQ6WALe3IRPmL/WHedLy6q/wnebyWuEa5r7tn+qFPeDEHkOJH mC5+mj32S0X7ge8qn5rp7IH5uj4pIRw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-301-CNWJ0NZXOiGTMERgaKJ7mw-1; Thu, 21 Nov 2019 10:22:28 -0500 Received: by mail-wr1-f69.google.com with SMTP id g17so2273656wru.4 for ; Thu, 21 Nov 2019 07:22:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=q5oLqWvnb0aRkILwjoxs7TO6LL3SaLwv0mw1Tnx1LeQ=; b=RXGqn4bgtEMCXPGlYg/99Pl52/FSke+8GlG271sNGjPEY7Ek4ny11R1E7DVcG2B7I1 Z6MhbrVo+VB01/GcC6L0hpKLnN3THw0Trg5wCAPAmb1UhKxPLbLMv+e3NaF04bVatVEH Y75zoIfreB0gM68svIjSkucd7lAz3kwcpSGSFXoE7TMtQxReQexY+7fLLIEbDIyCGIiy p5A8ar1aBaaluuZaVBM9sUVHIBPKEodcxx6tl63cXhcAa31w4MMFseiuw8KRGgWW1spX NSjbJkS+HH17gLnoIFZvYLnfWfuM+FGQW6eA+PTbNvboT9/ShQ8Ymp2ewmR2OlIVH/bO mRMA== X-Gm-Message-State: APjAAAW0w8Nasb0HBXvz45+cqCPzielgQx9LfxxSJP0m4xlt0G5FSntx qD1hrQVAS+i6mYfLp6N7NNIupZ/DBwgkf+ni5OLNACbsq0fBg8fyK2x4+uvQpBKK8hZHPksq/LS n4DkkJtFbbuJmMQ== X-Received: by 2002:a1c:de88:: with SMTP id v130mr11121036wmg.89.1574349747606; Thu, 21 Nov 2019 07:22:27 -0800 (PST) X-Google-Smtp-Source: APXvYqw5o74fNENljlABK/lYLkS4Feb3Z5APl0Uo7kzwgwsJYwbUqkLXAs+/ZhV+e5Ghi3Vv+B4xrA== X-Received: by 2002:a1c:de88:: with SMTP id v130mr11121010wmg.89.1574349747366; Thu, 21 Nov 2019 07:22:27 -0800 (PST) Return-Path: Received: from [192.168.1.35] (131.red-88-21-102.staticip.rima-tde.net. [88.21.102.131]) by smtp.gmail.com with ESMTPSA id x9sm3528102wru.32.2019.11.21.07.22.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2019 07:22:26 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v1 02/19] DynamicTablesPkg: Fix missing local header warning To: devel@edk2.groups.io, sami.mujawar@arm.com Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, Matteo.Carlini@arm.com, Stephanie.Hughes-Fitt@arm.com, nd@arm.com References: <20190823105539.13260-1-sami.mujawar@arm.com> <20190823105539.13260-3-sami.mujawar@arm.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Thu, 21 Nov 2019 16:22:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20190823105539.13260-3-sami.mujawar@arm.com> X-MC-Unique: CNWJ0NZXOiGTMERgaKJ7mw-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 8/23/19 12:55 PM, Sami Mujawar wrote: > The edk2 BaseTools report a warning if a local header file > is not listed under the [Sources] section in the INF file. >=20 > Add header files to the [Sources] section in the respective > INF files to fix the warnings. >=20 > Signed-off-by: Sami Mujawar > --- > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.= inf | 1 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf = | 3 ++- > DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf = | 1 + > 3 files changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTable= FactoryDxe.inf b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTab= leFactoryDxe.inf > index b47a690dd72702a2d7157cbb21249ba1d01d08cd..56b69591ac52ca3ba51250dc0= 1a0846b22442ce9 100644 > --- a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory= Dxe.inf > +++ b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory= Dxe.inf > @@ -25,6 +25,7 @@ [Sources] > DeviceTreeTableFactory/DeviceTreeTableFactory.c > DynamicTableFactoryDxe.c > SmbiosTableFactory/SmbiosTableFactory.c > + DynamicTableFactory.h > =20 > [Packages] > MdePkg/MdePkg.dec > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLib= Arm.inf b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.i= nf > index 3bbd0e7818c6172f9178b12a3d0960e2d298bca1..2f987e3b6d339d4b5f342cb52= b8dc712cf4e585c 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf > @@ -1,7 +1,7 @@ > ## @file > # IORT Table Generator > # > -# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. > +# Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > ## > @@ -18,6 +18,7 @@ [Defines] > =20 > [Sources] > IortGenerator.c > + IortGenerator.h > =20 > [Packages] > MdePkg/MdePkg.dec > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLib= Arm.inf b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.i= nf > index 3cb13d7d8fd3df04f3e16cc6161d9736f7579a80..2c7d19513d6ceea29fd9f271f= 983a6cf6d2c1046 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf > @@ -18,6 +18,7 @@ [Defines] > =20 > [Sources] > PpttGenerator.c > + PpttGenerator.h > =20 > [Packages] > EmbeddedPkg/EmbeddedPkg.dec >=20 Reviewed-by: Philippe Mathieu-Daude