From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC43021160A3A for ; Tue, 2 Oct 2018 03:14:00 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B677B8046B; Tue, 2 Oct 2018 10:13:59 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-142.rdu2.redhat.com [10.10.120.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7188B309136B; Tue, 2 Oct 2018 10:13:58 +0000 (UTC) To: Ruiyu Ni , Chao Zhang References: <20180828034257.19060-1-shenglei.zhang@intel.com> Cc: shenglei , edk2-devel@lists.01.org, Michael Kinney From: Laszlo Ersek Message-ID: Date: Tue, 2 Oct 2018 12:13:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180828034257.19060-1-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 02 Oct 2018 10:13:59 +0000 (UTC) Subject: Re: [PATCH v3 00/16] Removed unused PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 10:14:00 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Ray, Chao, guys, you keep breaking the development process. Please fix your email clients *now*. On 08/28/18 05:42, shenglei wrote: > shenglei (16): > IntelFsp2Pkg FspSecCore: Remove unused PCDs > IntelFsp2Pkg/BaseFspCommonLib: Remove unused PCDs > IntelFsp2Pkg/BaseFspPlatformLib: Remove unused PCDs > IntelFsp2Pkg/BaseFspSwitchStackLib: Remove unused PCDs > IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Remove an unused PCD > IntelFsp2WrapperPkg/BaseFspWrapperPlatformLibSample: Remove PCDs > SecurityPkg/Tcg2ConfigPei: Remove an unused PCD This was patch #07 in this series. I had never reviewed it, yet Chao pushed it with my R-b as commit https://github.com/tianocore/edk2/commit/3e11c27f67ea > SecurityPkg/Tcg2Dxe: Remove unused PCDs > UefiCpuPkg/CpuCommonFeaturesLib: Remove an unused PCD > MdePkg/BaseLib: Remove an unused PCD > MdeModulePkg/DxeCapsuleLibFmp: Remove unused PCDs > MdeModulePkg/FirmwarePerformanceDataTableDxe: Remove an unused PCD > ShellPkg/Shell: Remove unused PCDs This was patch #13 in this series. I reviewed it: http://mid.mail-archive.com/70dfa56d-6781-e8c0-f3f4-aa12558672b9@redhat.com but Ray pushed it as commit https://github.com/tianocore/edk2/commit/a9dfe53f56bb without my R-b tag. (Note: there was 1 month between my feedback and the push date.) The commit message now suggests that I ignored the patch (because I was on CC, but seemingly didn't respond). It mis-represents my acts. > ShellPkg/DpDynamicCommand: Remove unused PCDs > ShellPkg/UefiHandleParsingLib: Remove an unused PCD Same here. Patch #15, pushed as commit https://github.com/tianocore/edk2/commit/42a7c2871a65 My review was at: http://mid.mail-archive.com/a70f17d9-b937-2835-4d71-5464bad82219@redhat.com but it was dropped from the commit. > ShellPkg/UefiShellDebug1CommandsLib: Remove unused PCDs Ditto. Patch #16. My review was at: http://mid.mail-archive.com/d23e7c95-96e9-4088-4e95-5dbc0a331cb1@redhat.com but the patch was pushed as commit https://github.com/tianocore/edk2/commit/aa9986651bfe with my review lost. This is not the first time it has happened. If I remember correctly, Ray blamed his email client last time (not showing message threads correctly, or something similar). I'm sorry, but this is unacceptable. This is on-going, systemic disregard for the project's other participants. Please fix your mail user agents *now*. Here's my promise. Next time, I'm going to revert such commits (assuming I manage to catch them again). They do not represent the facts from the mailing list. Laszlo