From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Fri, 26 Apr 2019 10:02:29 -0700 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C2B243025498; Fri, 26 Apr 2019 17:02:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-104.rdu2.redhat.com [10.10.121.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id C1406101E7E9; Fri, 26 Apr 2019 17:02:25 +0000 (UTC) Subject: Re: [PATCH] EmbeddedPkg: Allow DXE_DRIVER to depend on NvVarStoreFormattedLib To: Ard Biesheuvel , Marcin Wojtas Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk , Kostya Porotchkin , Jici Gao , "Tian, Feng" , "Kinney, Michael D" , "Gao, Liming" References: <1556183880-5889-1-git-send-email-mw@semihalf.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 26 Apr 2019 19:02:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 26 Apr 2019 17:02:28 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/25/19 13:04, Ard Biesheuvel wrote: > On Thu, 25 Apr 2019 at 11:18, Marcin Wojtas wrote: >> >> Some modules (such as FaultTolerantWriteDxe) use the FlashNvStorage >> PCDs (PcdFlashNvStorageFtw*). In case the flash contents are not >> mapped in memory, the module loading order of the FVB driver >> may become important. >> >> To handle above, this patch allows to hook the dependency of >> desired DXE_DRIVER type module in the .DSC file via >> NvVarStoreFormattedLib NULL resolution. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 > > This line is no longer required, so you can drop it in the future. > > Note that the licensing terms have changed accordingly: by > contributing patches under the new license terms, you are basically > granting the same IP rights you were granting before by adhering to > the TianoCore Contribution Agreement, so nothing has really changed. > However, it is your *own* responsibility to confirm that I am not > misrepresenting anything here, so please check the repository for the > license changes. > >> Signed-off-by: Marcin Wojtas > > Reviewed-by: Ard Biesheuvel > > Pushed as b9d4847ec258..20029ca22baa patch looks good to me as well, thanks > > Thanks, >> --- >> EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf >> index fefc311..98a0049 100644 >> --- a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf >> +++ b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf >> @@ -39,8 +39,8 @@ >> # >> # The matching DEPEX section below will generate the EFI_SECTION_PEI_DEPEX, >> # EFI_SECTION_DXE_DEPEX or EFI_SECTION_MM_DEPEX leaf section for the PEIM >> -# (EFI_FV_FILETYPE_PEIM), DXE_RUNTIME_DRIVER (EFI_FV_FILETYPE_DRIVER), or >> +# (EFI_FV_FILETYPE_PEIM), DXE_RUNTIME_DRIVER/DXE_DRIVER (EFI_FV_FILETYPE_DRIVER), or >> # DXE_SMM_DRIVER (EFI_FV_FILETYPE_MM) module, respectively. >> # >> -[Depex.common.PEIM, Depex.common.DXE_RUNTIME_DRIVER, Depex.common.DXE_SMM_DRIVER] >> +[Depex.common.PEIM, Depex.common.DXE_RUNTIME_DRIVER, Depex.common.DXE_DRIVER, Depex.common.DXE_SMM_DRIVER] >> gEdkiiNvVarStoreFormattedGuid >> -- >> 2.7.4 >>