From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.51816.1643735258946632687 for ; Tue, 01 Feb 2022 09:07:39 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 962CA6D; Tue, 1 Feb 2022 09:07:38 -0800 (PST) Received: from [192.168.1.11] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 377AC3F40C; Tue, 1 Feb 2022 09:07:37 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSDT ACPI table To: Ard Biesheuvel Cc: Sami Mujawar , Rebecca Cran , "devel@edk2.groups.io" , Ard Biesheuvel , nd References: <20220128154103.20752-1-Pierre.Gondois@arm.com> <20220128154103.20752-6-Pierre.Gondois@arm.com> <52503b9c-c820-15b3-65c5-f2cc110f5027@quicinc.com> <60a12a54-1860-f7b8-f4f1-144cf19f347f@arm.com> <04ae07d5-4340-eca6-469b-41fb5a74a4e0@arm.com> From: "PierreGondois" Message-ID: Date: Tue, 1 Feb 2022 18:07:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/1/22 6:04 PM, Ard Biesheuvel wrote: > On Tue, 1 Feb 2022 at 18:02, Pierre Gondois wrote: >> >> >> >> On 2/1/22 5:56 PM, Ard Biesheuvel wrote: >>> On Tue, 1 Feb 2022 at 17:56, Ard Biesheuvel wrote: >>>> >>>> On Tue, 1 Feb 2022 at 17:55, Pierre Gondois wrote: >>>>> >>>>> Hi Rebecca, >>>>> >>>>> On 1/31/22 4:21 PM, Sami Mujawar wrote: >>>>>> Hi Rebecca, >>>>>> >>>>>> Thanks for catching this. >>>>>> >>>>>> I think we also need to adda check in Acpiview to report this issue. However, >>>>>> that would be another patch series. >>>>>> >>>>>> Regards, >>>>>> >>>>>> Sami Mujawar >>>>>> >>>>>> *From: *Rebecca Cran >>>>>> *Date: *Monday, 31 January 2022 at 15:17 >>>>>> *To: *devel@edk2.groups.io , Pierre Gondois >>>>>> >>>>>> *Cc: *Ard Biesheuvel , Sami Mujawar >>>>>> >>>>>> *Subject: *Re: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSDT ACPI table >>>>>> >>>>>> On 1/28/22 08:41, PierreGondois wrote: >>>>>> >>>>>>> + Differentiated System Description Table Fields (DSDT) >>>>>>> + >>>>>>> + Copyright (c) 2021 - 2022, ARM Ltd. All rights reserved.
>>>>>>> + SPDX-License-Identifier: BSD-2-Clause-Patent >>>>>>> + >>>>>>> +**/ >>>>>>> + >>>>>>> +DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-KVMT", 1) { >>>>>> >>>>>> The Revision field should probably be 2, not 1. ACPI 6.4 says: >>>>>> >>>>>> >>>>>> 2. This field also sets the global integer width for the AML >>>>>> interpreter. Values less than two will cause the inter- >>>>>> preter to use 32-bit integers and math. Values of two >>>>>> and greater will cause the interpreter to use full 64-bit >>>>>> integers and math. >>>>>> >>>>>> -- >>>>>> Rebecca Cran >>>>>> >>>>> >>>>> Yes indeed. I forgot to add it in the v4... I will send a v5. >>>> >>>> Please give me a minute before sending another version. >>>> >>>> I am still seeing >>> >>> No ACPI PMU IRQ for CPU26 >>> >>> errors and I am trying to figure out why. >>> >> >> There is a --pmu option in kvmtool, we are not populating pmu >> interrupts if kvmtool doesn't receive this option. Maybe this is it ? > > Yes you are right. > > So this is all looking fine now - I tested booting Linux with > pci=nomsi, and the legacy interrupts are level and working as > expected. > Ok nice. Thanks for testing. I will send the v5 shortly.