From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 76B35AC01FA for ; Fri, 1 Dec 2023 00:33:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UPqAagbVb426xUAivaIqWogl+PhcwT8WsRxjwwAadnQ=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701390787; v=1; b=hoXGLWx1nmWbnFJ0koH2yXYkixoK0DgJAchbsMKufEMjY9JYPW4DI+cWvWux3lu6aNAeDMgl vF8tXcEL4SQcUFTlAeI4uQ7BLMHe5H37iQh5OloXOMBKlMS8wINRsqr66QDt+h2EhCDnCczds4k te93MXkB7SGnrOWxybk3NmDE= X-Received: by 127.0.0.2 with SMTP id wc0oYY7687511xQ843EeWbM5; Thu, 30 Nov 2023 16:33:07 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.11619.1701390786498741956 for ; Thu, 30 Nov 2023 16:33:06 -0800 X-Received: from [192.168.4.22] (unknown [47.201.241.198]) by linux.microsoft.com (Postfix) with ESMTPSA id B983320B74C0; Thu, 30 Nov 2023 16:33:04 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B983320B74C0 Message-ID: Date: Thu, 30 Nov 2023 19:33:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1] Vlv2TbltDevicePkg: Fix DxeCore Build Failures To: devel@edk2.groups.io, nathaniel.l.desimone@intel.com Cc: Chasel Chiu , Ray Ni , Sai Chaganty , Liming Gao , Michael D Kinney , Zailiang Sun , Yi Qian , Taylor Beebe , Michael Kubacki References: <20231201001822.3346-1-nathaniel.l.desimone@intel.com> <20231201001822.3346-2-nathaniel.l.desimone@intel.com> From: "Michael Kubacki" In-Reply-To: <20231201001822.3346-2-nathaniel.l.desimone@intel.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 7AHZ9WtUxkZxKWzLvWYA6Luwx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=hoXGLWx1; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Michael Kubacki On 11/30/2023 7:18 PM, Nate DeSimone wrote: > Commit 7284c44 in edk2 introduces an incompatibility that causes any > project that uses DxeMain.inf to fail to build. This is due to the > addition of ImagePropertiesRecordLib, and a new added dependency on > that library in DxeMain. Platforms will not have this LibraryClass > defined in their DSC yet and hence currently fail to build. >=20 > This changes addes ImagePropertiesRecordLib to Vlv2TbltDevicePkg > and resolves the build failure. >=20 > Cc: Chasel Chiu > Cc: Ray Ni > Cc: Sai Chaganty > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Taylor Beebe > Cc: Michael Kubacki > Signed-off-by: Nate DeSimone > --- > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > 2 files changed, 2 insertions(+) >=20 > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platf= orm/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > index 4adbaa6966..0c66705377 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > @@ -209,6 +209,7 @@ > PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/Base= PeCoffExtraActionLibNull.inf > DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNul= l.inf > !endif > + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib= /ImagePropertiesRecordLib.inf > =20 > # > # CryptLib > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platfo= rm/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index c7d9733dad..0689f275f1 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -211,6 +211,7 @@ > PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/Base= PeCoffExtraActionLibNull.inf > DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNul= l.inf > !endif > + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib= /ImagePropertiesRecordLib.inf > =20 > # > # CryptLib -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111934): https://edk2.groups.io/g/devel/message/111934 Mute This Topic: https://groups.io/mt/102906247/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-