From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id C25BC7803D7 for ; Wed, 21 Aug 2024 10:38:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UqSjASmh50a1LwNqHWGtbjtE0Z1yAk++zGodp7KHoro=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1724236692; v=1; b=Su7/5+1S+DNWcTWXZ/pVSPNI72NBEzvOM2wCB7NOMVU7AaqLhW5K5Me4JRT7zsqZqmFbLfpf +RIwLjQH6+ri1avEaoxlzuHPrdY1MmWhtMXj3uO/RxdEajf9hIR+ooEHACIBfWhqXixW3DHF6xy nTK7UtZSKpoEBhR/W9rkGaPHXSZV1DJXPLJYOvwKzdTucfjvwt2cXU9ynCAek1E63qzMUMtlurx xatr9Rmm+dpPLK3rNg+G2VWr3zktg5gTg6+/tIG51PSq2VDQ+yPqIvRNvQsnGLKUDNLuLCxdRvM QdPWKxQb3b8nJ6rQIthR/8Qe16JB0rZ6MJQFPKa/wHtSA== X-Received: by 127.0.0.2 with SMTP id I7w7YY7687511x5QbscZwumk; Wed, 21 Aug 2024 03:38:11 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.16946.1724236690206733285 for ; Wed, 21 Aug 2024 03:38:10 -0700 X-Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-as3kIJJ-P66yMd920QdZEw-1; Wed, 21 Aug 2024 06:38:07 -0400 X-MC-Unique: as3kIJJ-P66yMd920QdZEw-1 X-Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BEC411955BF7; Wed, 21 Aug 2024 10:38:05 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.194.20]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 581831955DD6; Wed, 21 Aug 2024 10:38:05 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 210BE18011E8; Wed, 21 Aug 2024 12:38:03 +0200 (CEST) Date: Wed, 21 Aug 2024 12:38:03 +0200 From: "Gerd Hoffmann" To: Mike Beaton Cc: devel@edk2.groups.io, Ard Biesheuvel , dougflick@microsoft.com Subject: Re: [edk2-devel] Non-obvious network boot stack issues in OVMF after 4c4ceb2 (NetworkPkg: SECURITY PATCH CVE-2023-45237) Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 21 Aug 2024 03:38:10 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: POfYJCyHmwsGbycQ3tdVIFCAx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="Su7/5+1S"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Sat, Aug 10, 2024 at 10:08:20AM GMT, Mike Beaton wrote: > The network boot stack fails to load in OVMF after > 4c4ceb2ceb80c42fd5545b2a4bd80321f07f4345 (NetworkPkg: SECURITY PATCH > CVE-2023-45237): https://bugzilla.tianocore.org/show_bug.cgi?id=4827 > > I have now understood that this is because the network stack drivers > have been updated to require an instance of gEfiRngProtocolGuid, so > OVMF now requires the `-device virtio-rng-pci` qemu option in order > for the network stack to load (this flag is required in order for > VirtioRngDxe to be able to provide the required protocol). FYI: With the upcoming 2024-08 stable tag this will be relaxed, a CPU with rdrand instruction support will work too as source for random numbers. See https://github.com/tianocore/edk2/pull/5714 for details. > 1. This is rather non-obvious - previously, the user set the > compilation options for the network stack, and the network stack > started. Ideally, perhaps, this would be fixed by adding some > documentation somewhere easily found, but I am not sure where. (By the > way, we don't get any helpful asserts which would lead us in the right > direction; the depex is never satisfied, so the network stack drivers > just never load.) Yep. When it comes to diagnostics there is clearly room for improvement. > 2. I also spotted that OvmfXen has neither RngDxe nor VirtioRngDxe - I > have never used OvmfXen, so I am not sure about this but (since these > seem to be the only two drivers which produce gEfiRngProtocolGuid) at > least at first glance it looks as if OvmfXen won't have any RNG for > the network stack now, so that it's network stack would not start? There is a patch for that too in master branch, so upcoming 2024-08 should be fine here. It has been somewhat bumpy road due to the last minute merge of the fixes so some fallout has been fixed only after the 2024-05 stable tag. HTH & take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120387): https://edk2.groups.io/g/devel/message/120387 Mute This Topic: https://groups.io/mt/107822587/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-