From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.55022.1688463821516477458 for ; Tue, 04 Jul 2023 02:43:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LrDfzSPb; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688463820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=134o32U/HFiDbLKEjEh28gQjhDm2EdO6PR3sgV3o82g=; b=LrDfzSPb9gqo0Eo3QsaKejhSO29OEMlluUdj6sGZ22R11HDHC07nRog+Doo06rr6AVtLFC p6HS84bJ3/+PZGeqdidZDhBmWCdLqlYHtaXlQLpAkS7GiPi3jwB2biiuEfZtu+dJiq+FLe WlhYmLnOWWDDY88TdEuzAj7T2NLrrGY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-139-d6t_xshQMAO9zuiytf8VXw-1; Tue, 04 Jul 2023 05:43:37 -0400 X-MC-Unique: d6t_xshQMAO9zuiytf8VXw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 021C7800159; Tue, 4 Jul 2023 09:43:37 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.188]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BAAD6492C13; Tue, 4 Jul 2023 09:43:36 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D98D01800613; Tue, 4 Jul 2023 11:43:34 +0200 (CEST) Date: Tue, 4 Jul 2023 11:43:34 +0200 From: "Gerd Hoffmann" To: "Ni, Ray" Cc: "devel@edk2.groups.io" , Pawel Polawski , "Kumar, Rahul R" , Oliver Steffen , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode for cpu hotplug Message-ID: References: <20230307122037.3100651-1-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 24, 2023 at 12:32:24PM +0000, Ni, Ray wrote: > Gerd, > I was busy on something else. The patch was ready and I am testing it before sending them out. Ping. Any update? take care, Gerd > > Thanks, > Ray > > > > -----Original Message----- > > From: kraxel@redhat.com > > Sent: Wednesday, May 3, 2023 3:24 PM > > To: Ni, Ray > > Cc: devel@edk2.groups.io; Pawel Polawski ; Kumar, > > Rahul R ; Oliver Steffen ; > > Dong, Eric > > Subject: Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode > > for cpu hotplug > > > > On Tue, Mar 21, 2023 at 07:28:44AM +0000, Ni, Ray wrote: > > > > + } else if ((PcdGet32 (PcdCpuBootLogicalProcessorNumber) > 0) && > > > > + (PcdGet32 (PcdCpuMaxLogicalProcessorNumber) > 255)) > > > > + { > > > > + X2Apic = TRUE; > > > > > > Gerd, > > > I agree with your needs that want X2 APIC even the actual processor number > > in BIOS phase <= 255. > > > > > > Question: Is it possible that BIOS stays at XAPIC, and later OS switches to X2 > > APIC when the maximum CPU count > 255? > > > > > > I am thinking about adding a new PCD to tell MP code switch to x2 apic in the > > first time AP wakes up. Possible timeline for the code change is > > > about within 1 month. Do you think it can meet your needs? > > > > Ping. What is the status here? I'd like to see that fixed for OVMF > > for the next stable release, and freeze is coming closer ... > > > > take care, > > Gerd > --