From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 387B27803CC for ; Mon, 13 Nov 2023 12:29:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=39g+Hc5ezjvDUYurMgYEP1yoqIpsfkoRw7ZQTLDj/qI=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1699878543; v=1; b=QweLB4xPj/Xk9LwA63Xt0aj2XURHo/HKyp04FNhhMbZRRuJ6+njUjMPuH+65klL2ysEFuHmO +hseW/QiH9h5CbZRCLnmFERDWaVh/RBkLz6Why3tFzFRRXn3pn0kDoJVdgs/MQWUIhIOlUC1n4c cY+Cjobxe+WhWLE7lAZe2d00= X-Received: by 127.0.0.2 with SMTP id 9rBKYY7687511xNKEciJk66r; Mon, 13 Nov 2023 04:29:03 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.35535.1699878542986180348 for ; Mon, 13 Nov 2023 04:29:03 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-44-DeQYketENoKCJrBR2c5yYw-1; Mon, 13 Nov 2023 07:28:58 -0500 X-MC-Unique: DeQYketENoKCJrBR2c5yYw-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 73AC1101A54C; Mon, 13 Nov 2023 12:28:58 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.194.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 36B225031; Mon, 13 Nov 2023 12:28:58 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id EFA1A1804A63; Mon, 13 Nov 2023 13:28:56 +0100 (CET) Date: Mon, 13 Nov 2023 13:28:56 +0100 From: "Gerd Hoffmann" To: xieyuanh Cc: devel@edk2.groups.io, Eric Dong , Ray Ni , Rahul Kumar Subject: Re: [edk2-devel] [Patch V4] UefiCpuPkg/MpInitLib: Enable execute disable bit. Message-ID: References: <20231113055948.1773-1-yuanhao.xie@intel.com> MIME-Version: 1.0 In-Reply-To: <20231113055948.1773-1-yuanhao.xie@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: PaUEZwmWMRZN54AeShcsYzSex7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=QweLB4xP; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Nov 13, 2023 at 01:59:48PM +0800, xieyuanh wrote: > From: Yuanhao Xie > > This patch synchronizes the No-Execute bit in the IA32_EFER > register for the APs before the RestoreVolatileRegisters operation. > > The commit 964a4f0, titled "Eliminate the second INIT-SIPI-SIPI > sequence," replaces the second INIT-SIPI-SIPI sequence with the BSP > calling the SwitchApContext function to initiate a specialized start-up > signal, waking up APs in the DXE instead of using INIT-SIPI-SIPI. > > Due to this change, the logic for "Enable execute disable bit" in > MpFuncs.nasm is no longer executed. However, to ensure the proper setup > of the page table, it is necessary to synchronize the IA32_EFER.NXE for > APs before executing RestoreVolatileRegisters . > > Based on SDM: > If IA32_EFER.NXE is set to 1, it signifies execute-disable, meaning > instruction fetches are not allowed from the 4-KByte page controlled by > this entry. Conversely, if it is set to 0, it is reserved. > > Signed-off-by: Yuanhao Xie > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111148): https://edk2.groups.io/g/devel/message/111148 Mute This Topic: https://groups.io/mt/102556608/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-