* [Patch 1/1] OvmfPkg/VirtIoSerialDxe: Update for VS2015x86 compatibility
@ 2023-05-26 23:17 Michael D Kinney
2023-05-27 9:07 ` Ard Biesheuvel
2023-05-31 7:33 ` [edk2-devel] " Gerd Hoffmann
0 siblings, 2 replies; 3+ messages in thread
From: Michael D Kinney @ 2023-05-26 23:17 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Jiewen Yao, Jordan Justen, Gerd Hoffmann
Move initialization of local variable structure from declaration
to statements to fix VS2015x86 build break.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
OvmfPkg/VirtioSerialDxe/VirtioSerial.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
index bfb2b324eadf..df545c080e9d 100644
--- a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
+++ b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
@@ -66,11 +66,11 @@ VirtioSerialTxControl (
IN UINT16 Value
)
{
- VIRTIO_SERIAL_CONTROL Control = {
- .Id = Id,
- .Event = Event,
- .Value = Value,
- };
+ VIRTIO_SERIAL_CONTROL Control;
+
+ Control.Id = Id;
+ Control.Event = Event;
+ Control.Value = Value;
DEBUG ((
DEBUG_INFO,
--
2.40.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Patch 1/1] OvmfPkg/VirtIoSerialDxe: Update for VS2015x86 compatibility
2023-05-26 23:17 [Patch 1/1] OvmfPkg/VirtIoSerialDxe: Update for VS2015x86 compatibility Michael D Kinney
@ 2023-05-27 9:07 ` Ard Biesheuvel
2023-05-31 7:33 ` [edk2-devel] " Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2023-05-27 9:07 UTC (permalink / raw)
To: Michael D Kinney
Cc: devel, Ard Biesheuvel, Jiewen Yao, Jordan Justen, Gerd Hoffmann
On Sat, 27 May 2023 at 01:17, Michael D Kinney
<michael.d.kinney@intel.com> wrote:
>
> Move initialization of local variable structure from declaration
> to statements to fix VS2015x86 build break.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> OvmfPkg/VirtioSerialDxe/VirtioSerial.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
> index bfb2b324eadf..df545c080e9d 100644
> --- a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
> +++ b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c
> @@ -66,11 +66,11 @@ VirtioSerialTxControl (
> IN UINT16 Value
> )
> {
> - VIRTIO_SERIAL_CONTROL Control = {
> - .Id = Id,
> - .Event = Event,
> - .Value = Value,
> - };
> + VIRTIO_SERIAL_CONTROL Control;
> +
> + Control.Id = Id;
> + Control.Event = Event;
> + Control.Value = Value;
>
> DEBUG ((
> DEBUG_INFO,
> --
> 2.40.1.windows.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [edk2-devel] [Patch 1/1] OvmfPkg/VirtIoSerialDxe: Update for VS2015x86 compatibility
2023-05-26 23:17 [Patch 1/1] OvmfPkg/VirtIoSerialDxe: Update for VS2015x86 compatibility Michael D Kinney
2023-05-27 9:07 ` Ard Biesheuvel
@ 2023-05-31 7:33 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2023-05-31 7:33 UTC (permalink / raw)
To: devel, michael.d.kinney; +Cc: Ard Biesheuvel, Jiewen Yao, Jordan Justen
On Fri, May 26, 2023 at 04:17:34PM -0700, Michael D Kinney wrote:
> Move initialization of local variable structure from declaration
> to statements to fix VS2015x86 build break.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-31 7:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-26 23:17 [Patch 1/1] OvmfPkg/VirtIoSerialDxe: Update for VS2015x86 compatibility Michael D Kinney
2023-05-27 9:07 ` Ard Biesheuvel
2023-05-31 7:33 ` [edk2-devel] " Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox