From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Ni, Ray" <ray.ni@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Pawel Polawski <ppolawsk@redhat.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
Oliver Steffen <osteffen@redhat.com>,
"Dong, Eric" <eric.dong@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode for cpu hotplug
Date: Wed, 3 May 2023 09:24:11 +0200 [thread overview]
Message-ID: <ghvtf7sj3orpd3jgwrtwrgyfvcv43ta6xvd7z4fizfyglu7x7d@ltfv7ykk6utz> (raw)
In-Reply-To: <MN6PR11MB82445F9CB170B40A73FFED2C8C819@MN6PR11MB8244.namprd11.prod.outlook.com>
On Tue, Mar 21, 2023 at 07:28:44AM +0000, Ni, Ray wrote:
> > + } else if ((PcdGet32 (PcdCpuBootLogicalProcessorNumber) > 0) &&
> > + (PcdGet32 (PcdCpuMaxLogicalProcessorNumber) > 255))
> > + {
> > + X2Apic = TRUE;
>
> Gerd,
> I agree with your needs that want X2 APIC even the actual processor number in BIOS phase <= 255.
>
> Question: Is it possible that BIOS stays at XAPIC, and later OS switches to X2 APIC when the maximum CPU count > 255?
>
> I am thinking about adding a new PCD to tell MP code switch to x2 apic in the first time AP wakes up. Possible timeline for the code change is
> about within 1 month. Do you think it can meet your needs?
Ping. What is the status here? I'd like to see that fixed for OVMF
for the next stable release, and freeze is coming closer ...
take care,
Gerd
next prev parent reply other threads:[~2023-05-03 7:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 12:20 [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode for cpu hotplug Gerd Hoffmann
2023-03-20 9:56 ` Gerd Hoffmann
2023-03-21 7:28 ` [edk2-devel] " Ni, Ray
2023-03-21 11:53 ` Gerd Hoffmann
2023-03-23 2:45 ` Ni, Ray
2023-05-03 7:24 ` Gerd Hoffmann [this message]
2023-05-24 12:32 ` Ni, Ray
2023-07-04 9:43 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ghvtf7sj3orpd3jgwrtwrgyfvcv43ta6xvd7z4fizfyglu7x7d@ltfv7ykk6utz \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox