Re: [edk2-devel] [PATCH 1/2] OvmfPkg/AmdSev: fix BdsPlatform.c assertion failure during boot

["Gerd Hoffmann" <kraxel@redhat.com>]

On Wed, Aug 16, 2023 at 03:11:45PM -0500, Michael Roth wrote:
> Booting an SEV guest with AmdSev OVMF package currently triggers the
> following assertion with QEMU:
> 
>   InstallQemuFwCfgTables: installed 7 tables
>   PcRtc: Write 0x20 to CMOS location 0x32
>   [Variable]END_OF_DXE is signaled
>   Initialize variable error flag (FF)
> 
>   ASSERT_EFI_ERROR (Status = Not Found)
>   ASSERT [BdsDxe] /home/VT_BUILD/ovmf/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c(1711): !(((INTN)(RETURN_STATUS)(Status)) < 0)
> 
> This seems to be due to commit 81dc0d8b4c, which switched to using
> PlatformBootManagerLib instead of PlatformBootManagerLibGrub. That
> pulls in a dependency on gEfiS3SaveStateProtocolGuid provider being
> available (which is asserted for in
> BdsPlatform.c:PlatformBootManagerBeforeConsole()/SaveS3BootScript()),
> but the libraries that provide it aren't currently included in the
> build. Add them similarly to what's done for OvmfPkg.
> 
> Fixes: 81dc0d8b4c ("OvmfPkg/AmdSev: stop using PlatformBootManagerLibGrub")
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Signed-off-by: Michael Roth <michael.roth@amd.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

should be added to the stable tag.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107916): https://edk2.groups.io/g/devel/message/107916
Mute This Topic: https://groups.io/mt/100787519/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-