From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C842F7803D7 for ; Mon, 21 Aug 2023 14:29:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QkJRI5JJjH6wX0ct9Yu72ejM9ESesJq58hI0Qt3UfDs=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1692628149; v=1; b=Cqf0kDdqTnAYCOMWk6Fo/ZG57f9BAP54nKtca5mKSdcoSlgrimuPGWdFPCvI0cdWAMPTmKXo 338EtAGxu13WzA2eivqOo6aUWJjlEoetV2ru2bIlHfuG5h9Z4ELoQVXimxhgJ7YAyln5P5A9nqC nBTnbr0wEuJPYFL+0E8iRlnk= X-Received: by 127.0.0.2 with SMTP id GJZ1YY7687511xeYxFMCmXIp; Mon, 21 Aug 2023 07:29:09 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.737.1692628148236984632 for ; Mon, 21 Aug 2023 07:29:08 -0700 X-Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-608-1fDpKhRwMmaNW56Bb2J5JA-1; Mon, 21 Aug 2023 10:29:04 -0400 X-MC-Unique: 1fDpKhRwMmaNW56Bb2J5JA-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A00D51C04B7B; Mon, 21 Aug 2023 14:29:02 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.194.126]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 647B31121314; Mon, 21 Aug 2023 14:29:02 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 00A0C18009DC; Mon, 21 Aug 2023 16:29:00 +0200 (CEST) Date: Mon, 21 Aug 2023 16:29:00 +0200 From: "Gerd Hoffmann" To: Michael Roth Cc: devel@edk2.groups.io, Ray Ni , Erdem Aktas , James Bottomley , Jiewen Yao , Min Xu , Tom Lendacky Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg/AmdSev: fix BdsPlatform.c assertion failure during boot Message-ID: References: <20230816201146.1634348-1-michael.roth@amd.com> <20230816201146.1634348-2-michael.roth@amd.com> MIME-Version: 1.0 In-Reply-To: <20230816201146.1634348-2-michael.roth@amd.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OH8d4kO6JsLFPqIxbkL2JLAVx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Cqf0kDdq; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Aug 16, 2023 at 03:11:45PM -0500, Michael Roth wrote: > Booting an SEV guest with AmdSev OVMF package currently triggers the > following assertion with QEMU: > > InstallQemuFwCfgTables: installed 7 tables > PcRtc: Write 0x20 to CMOS location 0x32 > [Variable]END_OF_DXE is signaled > Initialize variable error flag (FF) > > ASSERT_EFI_ERROR (Status = Not Found) > ASSERT [BdsDxe] /home/VT_BUILD/ovmf/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c(1711): !(((INTN)(RETURN_STATUS)(Status)) < 0) > > This seems to be due to commit 81dc0d8b4c, which switched to using > PlatformBootManagerLib instead of PlatformBootManagerLibGrub. That > pulls in a dependency on gEfiS3SaveStateProtocolGuid provider being > available (which is asserted for in > BdsPlatform.c:PlatformBootManagerBeforeConsole()/SaveS3BootScript()), > but the libraries that provide it aren't currently included in the > build. Add them similarly to what's done for OvmfPkg. > > Fixes: 81dc0d8b4c ("OvmfPkg/AmdSev: stop using PlatformBootManagerLibGrub") > Cc: Gerd Hoffmann > Cc: Ray Ni > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Min Xu > Cc: Tom Lendacky > Signed-off-by: Michael Roth Acked-by: Gerd Hoffmann should be added to the stable tag. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107916): https://edk2.groups.io/g/devel/message/107916 Mute This Topic: https://groups.io/mt/100787519/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-