From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2FDC5740046 for ; Mon, 22 Jan 2024 10:15:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mo3EMr3IJAAPBnSR9KqYa+gf9L/3fYKn1KOYhcenl6g=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1705918522; v=1; b=GnMM9h9f43VioiYaukAatV1dmEWUWB/122EbQSNKZ5VQwv2bwixgxwADCXdDEY4WuD/Wpz2A rR+3X/UIb+8b8Fc4NG2y1zofq5mf9V7wOEHIY5ic25/tjh0GMUytv8AreqnNrOwD+nqXWYhq+ce 4Ul3TA4omeRk4Qw4vnjYzmUc= X-Received: by 127.0.0.2 with SMTP id V7h5YY7687511xmIR3GCAFb0; Mon, 22 Jan 2024 02:15:22 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.70289.1705918522045925919 for ; Mon, 22 Jan 2024 02:15:22 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-421-hoL_SZ-zNWGeQZFuH4ekKw-1; Mon, 22 Jan 2024 05:15:16 -0500 X-MC-Unique: hoL_SZ-zNWGeQZFuH4ekKw-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CF57E85A588; Mon, 22 Jan 2024 10:15:15 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A05E8492BE2; Mon, 22 Jan 2024 10:15:15 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 66D84180038B; Mon, 22 Jan 2024 11:15:14 +0100 (CET) Date: Mon, 22 Jan 2024 11:15:14 +0100 From: "Gerd Hoffmann" To: Michael Brown Cc: devel@edk2.groups.io, ray.ni@intel.com, Laszlo Ersek , Pedro Falcato , "Kinney, Michael D" , "Desimone, Nathaniel L" , "Kumar, Rahul R" , "Liu, Zhiguang" Subject: Re: [edk2-devel] [PATCH 1/6] UefiCpuPkg/LocalApicTimerDxe: Duplicate OvmfPkg/LocalApicTimerDxe driver Message-ID: References: <0102018d11ac8fe8-1ce1e102-af57-426f-bafc-7297bec4799a-000000@eu-west-1.amazonses.com> <0102018d12d8bd9f-d209332f-f501-498e-b43c-3b0cc4f7ef7b-000000@eu-west-1.amazonses.com> <0102018d17080a28-370d97eb-b73c-4811-a9ea-05cfb459ba37-000000@eu-west-1.amazonses.com> <0102018d22d0f904-3aa0bdff-abe9-4c74-8316-0dc17122f372-000000@eu-west-1.amazonses.com> MIME-Version: 1.0 In-Reply-To: <0102018d22d0f904-3aa0bdff-abe9-4c74-8316-0dc17122f372-000000@eu-west-1.amazonses.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1YHz0A2zONes5LPVk6CKn0BDx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=GnMM9h9f; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > I do appreciate that it's difficult to understand the internals of > NestedInterruptTplLib. It's fundamentally having to solve a very difficult > problem within the constraints of the UEFI API. I think the solution that > NestedInterruptTplLib provides is as simple as it's possible to get, and it > does at least have the advantage that all of the complexity is hidden inside > the library. I think NestedInterruptTplLib is a good solution for the problem and I fully support moving it to MdeModulePkg. Yes, the library is complex. I reviewed it when it was merged to OvmfPkg, and even with the very good comments it took me a few hours to fully understand the logic. But the problem is complex too, I also think there is no simpler way to solve it. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114139): https://edk2.groups.io/g/devel/message/114139 Mute This Topic: https://groups.io/mt/103734961/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-