From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5CC6DD81163 for ; Mon, 12 Feb 2024 15:13:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gBKW38MHhKvjj0iJhsHEoJOGvlToUIsBf705NcAWoRY=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1707750833; v=1; b=qJGr9vJVOsFXF6gBdxcwhQSAF0AdNEwfyzfSd7jZx5OVUOyYj8X4ipovFViXlpN5C8+kXwXH GS2ceT2GIatFSw9nWq1KlAaf5x3j7C0BfctVXMuvIdmHtFHY1mwZ5fM+adomPTOEiqG8OMDpqpu GcEi7JhJLlgLwwTb2LpQMc7g= X-Received: by 127.0.0.2 with SMTP id JBLwYY7687511xCefoM1Ys9d; Mon, 12 Feb 2024 07:13:53 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.8674.1707750832282890601 for ; Mon, 12 Feb 2024 07:13:52 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-WTZw_ShONuC86m24g5JwvA-1; Mon, 12 Feb 2024 10:13:48 -0500 X-MC-Unique: WTZw_ShONuC86m24g5JwvA-1 X-Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C06F88A67E1; Mon, 12 Feb 2024 15:13:47 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.142]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 27110492BC9; Mon, 12 Feb 2024 15:13:47 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id E459C1800D4D; Mon, 12 Feb 2024 16:13:45 +0100 (CET) Date: Mon, 12 Feb 2024 16:13:45 +0100 From: "Gerd Hoffmann" To: devel@edk2.groups.io, thomas.lendacky@amd.com Cc: "Xu, Min M" , "Aktas, Erdem" , Oliver Steffen , "Yao, Jiewen" , Ard Biesheuvel , Michael Roth , Liming Gao , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v2 0/5] OvmfPkg: Add support for 5-level paging Message-ID: References: <20240130123204.764453-1-kraxel@redhat.com> <3jj3lyr7gmuzzdp6f7dnj3ow6sox5uikdx7ysb6xuoxryghuzn@r3jatiaty24n> <0ed8abc3-e2ce-6468-1a10-bf53be129b7f@amd.com> MIME-Version: 1.0 In-Reply-To: <0ed8abc3-e2ce-6468-1a10-bf53be129b7f@amd.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: yKcurQlLCAND7ha7a5m09AHvx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=qJGr9vJV; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On Fri, Feb 02, 2024 at 01:28:47PM -0600, Lendacky, Thomas via groups.io wrote: > On 2/2/24 02:44, Gerd Hoffmann wrote: > > On Fri, Feb 02, 2024 at 08:30:23AM +0000, Xu, Min M wrote: > > > > Pushed branch with two experimental patches: > > > > https://github.com/kraxel/edk2/commits/devel/paging-5lvl/ > > > > > > > > One for tdx, writing different values into TDX_WORK_AREA_PGTBL_READY for > > > > 4-level and 5-level paging modes. > > > > > > > > One for sev, which adds a 2-level page directory for the first gigabyte and > > > > places it at the same physical address it has in 4-level paging. > > > > With that SevClearPageEncMaskForGhcbPage should work unmodified in 5- > > > > level mode. > > > > > > > > Test results are welcome. > > > > > > Thanks Gerd, it works in TDX. One typo in the patch that pageTableEntriesLoopla57 and pageTableEntriesLoopLa57. > > > > Thanks for testing. > > > > Added a second sev patch to the branch, rearranging the #vc > > handler uninstall to make the la57 cpuid checks work on sev. > > > > @Tom: Would be great if you can give this a test > > So this gets us past the ASM code CPUID instructions, however, the > SEV support is still assuming 4-level paging and so: Thanks for testing. So, with the patch series the ResetVector is ready for 5-level paging. Good start. I'll go over the series and will send an update later (not urgent, it's post-freeze material anyway). > SEV ASSERT: > AmdSevDxe:SetMemoryEncDec: bad PML4 for Physical=0x8000000000 As expected. > FYI, this uncovered an SNP CPUID table processing bug in the ResetVector > code and so I sent a fix to the mailing list. I see the fix already merged. Nice. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115351): https://edk2.groups.io/g/devel/message/115351 Mute This Topic: https://groups.io/mt/104052206/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-