From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Corvin Köhne" <corvink@freebsd.org>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Peter Grehan <grehan@freebsd.org>,
Rebecca Cran <rebecca@bsdio.com>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [PATCH v2 1/6] OvmfPkg/Library: fix definition of GetAcpiRsdpFromMemory
Date: Tue, 20 Jun 2023 11:22:56 +0200 [thread overview]
Message-ID: <gxikysp6vjoxn4uio76xsv4amfltod7w2dds46fdyjwb2reeah@4uokvluohxta> (raw)
In-Reply-To: <20230619131255.364358-2-corvink@FreeBSD.org>
On Mon, Jun 19, 2023 at 03:12:23PM +0200, Corvin Köhne wrote:
> The definition and declaration of GetAcpiRsdpFromMemory doesn't match.
> We don't get a compile error yet because UINTN is the same as UINT64 on
> 64bit machines. As the function works on memory addresses, UINTN is the
> correct type of the input parameters.
Tested-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
next prev parent reply other threads:[~2023-06-20 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 13:12 [PATCH v2 0/6] OvmfPkg/Bhyve: install ACPI tables by FwCfg Corvin Köhne
2023-06-19 13:12 ` [PATCH v2 1/6] OvmfPkg/Library: fix definition of GetAcpiRsdpFromMemory Corvin Köhne
2023-06-20 9:22 ` Gerd Hoffmann [this message]
2023-06-19 13:12 ` [PATCH v2 2/6] OvmfPkg: avoid including AcpiPlatformLib twice Corvin Köhne
2023-06-19 13:12 ` [PATCH v2 3/6] OvmfPkg: move PciEncoding into AcpiPlatformLib Corvin Köhne
2023-06-19 13:12 ` [PATCH v2 4/6] OvmfPkg: move BootScript " Corvin Köhne
2023-06-19 13:12 ` [PATCH v2 5/6] OvmfPkg: move QemuFwCfgAcpi " Corvin Köhne
2023-06-19 13:12 ` [PATCH v2 6/6] OvmfPkg/Bhyve: install Acpi tables provided by FwCfg Corvin Köhne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gxikysp6vjoxn4uio76xsv4amfltod7w2dds46fdyjwb2reeah@4uokvluohxta \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox