From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.6321.1687252981655495766
 for <devel@edk2.groups.io>;
 Tue, 20 Jun 2023 02:23:01 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UF6H6v9Q;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1687252980;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JBMuTLFmlsErrXbYtFQXEgPdOW9tAspKjinQdhYuhqY=;
	b=UF6H6v9QihbnnZN7H9b0uTg0nfEzOoksHaG+TglE5xUj/j0HAJCsTjgEca5Px31F9pHNC3
	JV0MCPE24fE5g1ZvZgtg8AJJ81l5JFmgWvgf7K+kAyFHKFoLXBu39qMImot57rGZC9xuDb
	TJQO7QC1AZlAkH72FSbRjhkOPuNgyBM=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-539-7zjVGyrlPHKYEwvpGAvocQ-1; Tue, 20 Jun 2023 05:22:59 -0400
X-MC-Unique: 7zjVGyrlPHKYEwvpGAvocQ-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2E99F185A792;
	Tue, 20 Jun 2023 09:22:58 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.126])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id DE3A81400C34;
	Tue, 20 Jun 2023 09:22:57 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 7D9D71803082; Tue, 20 Jun 2023 11:22:56 +0200 (CEST)
Date: Tue, 20 Jun 2023 11:22:56 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Corvin =?utf-8?B?S8O2aG5l?= <corvink@freebsd.org>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>, 
	Jiewen Yao <jiewen.yao@intel.com>, Jordan Justen <jordan.l.justen@intel.com>, 
	Leif Lindholm <quic_llindhol@quicinc.com>, Peter Grehan <grehan@freebsd.org>, 
	Rebecca Cran <rebecca@bsdio.com>, Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [PATCH v2 1/6] OvmfPkg/Library: fix definition of GetAcpiRsdpFromMemory
Message-ID: <gxikysp6vjoxn4uio76xsv4amfltod7w2dds46fdyjwb2reeah@4uokvluohxta>
References: <20230619131255.364358-1-corvink@FreeBSD.org>
 <20230619131255.364358-2-corvink@FreeBSD.org>
MIME-Version: 1.0
In-Reply-To: <20230619131255.364358-2-corvink@FreeBSD.org>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Mon, Jun 19, 2023 at 03:12:23PM +0200, Corvin Köhne wrote:
> The definition and declaration of GetAcpiRsdpFromMemory doesn't match.
> We don't get a compile error yet because UINTN is the same as UINT64 on
> 64bit machines. As the function works on memory addresses, UINTN is the
> correct type of the input parameters.

Tested-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd