From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web10.7598.1682068999947054062
 for <devel@edk2.groups.io>;
 Fri, 21 Apr 2023 02:23:20 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IFTm3L3D;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1682068999;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=juc/V+979Xln0y/ECthrDjMFAWmVXwYIAoFloyJwF5g=;
	b=IFTm3L3DPQ0Ly1SMJwugtZQmH9KFjiahZb/2h6DO48nZJq0sxgn/T4S9NGJPCj58a0XT3t
	xx0P62JCEfx6VlciZ72d3piHSDWW/60AjJ37LPxsJqFLzWrl6dV03fsv390ErwEfu8ZCmw
	nFMidGJmNuln6HjW2FALQ0Y5zcU8Ya0=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-108-RBbHK40KOlaGWYozbA5N_A-1; Fri, 21 Apr 2023 05:23:15 -0400
X-MC-Unique: RBbHK40KOlaGWYozbA5N_A-1
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 091D7811E7B;
	Fri, 21 Apr 2023 09:23:15 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.59])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 5FD52492C13;
	Fri, 21 Apr 2023 09:23:14 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 2B7E41800083; Fri, 21 Apr 2023 11:23:13 +0200 (CEST)
Date: Fri, 21 Apr 2023 11:23:13 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Marvin =?utf-8?Q?H=C3=A4user?= <mhaeuser@posteo.de>
Cc: devel@edk2.groups.io, Yuwei Chen <yuwei.chen@intel.com>, 
	Oliver Steffen <osteffen@redhat.com>, Bob Feng <bob.c.feng@intel.com>, 
	Daniel Schaefer <git@danielschaefer.me>, Chao Li <lichao@loongson.cn>, 
	Dongyan Qian <qiandongyan@loongson.cn>, Michael D Kinney <michael.d.kinney@intel.com>, 
	Pawel Polawski <ppolawsk@redhat.com>, Baoqi Zhang <zhangbaoqi@loongson.cn>, 
	Leif Lindholm <quic_llindhol@quicinc.com>, Rebecca Cran <rebecca@bsdio.com>, 
	Zhiguang Liu <zhiguang.liu@intel.com>, Sunil V L <sunilvl@ventanamicro.com>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>, Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [PATCH v5 02/10] MdePkg: don't set visibility to hidden
Message-ID: <h55ni22tvyzc6p2wdca4imk2d3bjflekr5a2muakpjosckyrck@yi3hie27kg3k>
References: <zd6ghzbnlau3gjmmm6fmjrwhrpok42hw374r6j66hofbkxqqoc@6w6nbdejngyy>
 <892F3684-76F7-4143-B938-9AA7A2D6F168@posteo.de>
MIME-Version: 1.0
In-Reply-To: <892F3684-76F7-4143-B938-9AA7A2D6F168@posteo.de>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

> > Patch #1, adding a linker script assert as suggested by ard, then:
> > 
> > * compile + test on my local workstation (fedora 37, gcc 12).
> > * run CI
> > * compile on some older distros:
> >   - rhel-8 (gcc 8)
> >   - ubuntu-18.04 (gcc 7)
> 
> Did you include NOOPT? GCC5 specifies USING_LTO for DEBUG and RELEASE, thus the visibility would not be changed anyway.

CI does noopt builds.

take care,
  Gerd