From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1F75674004A for ; Thu, 30 May 2024 09:03:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=l8FBWYK1rEQdH4g6cYGH8jrO5NSrwo3iSV4bP4wqvbA=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20240206; t=1717059800; v=1; b=U8YNDfcrENEpbt1KHc5abbD1Y3KYQuscx/Yt+AiSefnx3DgteMSOVXiUkIVubN8doBdvGMbd LgAvfq/wKC0WhNnSiQdcURQAghWRf+C9XBx+8kfqaBMDxM+Vjv8COFn1kSSJTSzjFmBaaKVSgzD /Rg5PTsWX8vA4ZQpbGXOmXvOz6FX3UASF89QM+oRJ2N+xURhejdOwc2tLwNqbUuxK4OaReIwR4G 1WZ6z/5xope09I8k4Kx1eWp2OPExlbrb9RGiOD7+t7DEku16Nd1Fo5BqwgnwlB0aE/ExfVyn06U RbmRcyiWxMzA16ZaQ4U6+W9S1/GyY0qyXjDaLq5IcGJZQ== X-Received: by 127.0.0.2 with SMTP id KaIFYY7687511xOEWUKI4aHs; Thu, 30 May 2024 02:03:19 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.3864.1717059798903763663 for ; Thu, 30 May 2024 02:03:19 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-_RFvvhEwMOSiC2zj9uq3Ug-1; Thu, 30 May 2024 05:03:15 -0400 X-MC-Unique: _RFvvhEwMOSiC2zj9uq3Ug-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 56B9D81227E; Thu, 30 May 2024 09:03:15 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.101]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B0F6C40004D; Thu, 30 May 2024 09:03:14 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id C6B1318000A9; Thu, 30 May 2024 11:03:13 +0200 (CEST) Date: Thu, 30 May 2024 11:03:13 +0200 From: "Gerd Hoffmann" To: Corvin =?utf-8?B?S8O2aG5l?= Cc: devel@edk2.groups.io, Michael Roth , Oliver Steffen , Jiewen Yao , Tom Lendacky , Laszlo Ersek , Min Xu , Ard Biesheuvel , Erdem Aktas Subject: Re: [edk2-devel] [PATCH v3 1/4] OvmfPkg/Sec: Setup MTRR early in the boot process. Message-ID: References: <20240130130441.772484-1-kraxel@redhat.com> <20240130130441.772484-2-kraxel@redhat.com> <78c0f23dbca552daefd01ca10751a10392a8af04.camel@FreeBSD.org> MIME-Version: 1.0 In-Reply-To: <78c0f23dbca552daefd01ca10751a10392a8af04.camel@FreeBSD.org> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 30 May 2024 02:03:19 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: NF3SNhzspuGwNi3ADwvQXTyex7686176AA= Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=U8YNDfcr; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > > -    SetMem (&MtrrSettings.Fixed, sizeof MtrrSettings.Fixed, 0x06); > > +    SetMem (&MtrrSettings.Fixed, sizeof MtrrSettings.Fixed, > > MTRR_CACHE_WRITE_BACK); > >      ZeroMem (&MtrrSettings.Variables, sizeof > > MtrrSettings.Variables); > > -    MtrrSettings.MtrrDefType |= BIT11 | BIT10 | 6; > > +    MtrrSettings.MtrrDefType |= BIT10; > >      MtrrSetAllMtrrs (&MtrrSettings); > >   > >      // > > This has to be changed for OvmfPkg/Bhyve/PlatformPei/MemDetect.c too. I have a draft PR open with this fixed: https://github.com/tianocore/edk2/pull/5696 Can you check this works for bhyve? thanks, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119383): https://edk2.groups.io/g/devel/message/119383 Mute This Topic: https://groups.io/mt/104052591/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-