From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9CBFB740034 for ; Tue, 19 Sep 2023 07:59:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Kc6dnnhdbzzEyj1XR8X8PO99HnnKHsnH6GeppIIj1Jk=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1695110378; v=1; b=fDGtQ75gCUgFF840TGWzfLbpmKlO/nQTo4GDkhMWefB2X42qTOXCpQUdosvwjsyBzf41t2Ft SgIGEjvZyb3woYuSa0uHMmM0Ssr6Nd46rWhKI5MnNJKp8kKO4avIY6yfulZXwZo+EaIpA0l+rgw 3lcYbgayR3q2rF1g7Cx6EjXU= X-Received: by 127.0.0.2 with SMTP id kotAYY7687511xPAnOU7CBnK; Tue, 19 Sep 2023 00:59:38 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.2806.1695110377444483754 for ; Tue, 19 Sep 2023 00:59:37 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-662-UWW8YwSLPNesSgkl5yMMLw-1; Tue, 19 Sep 2023 03:59:30 -0400 X-MC-Unique: UWW8YwSLPNesSgkl5yMMLw-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D03B51E441C1; Tue, 19 Sep 2023 07:59:29 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F62E18EC1; Tue, 19 Sep 2023 07:59:29 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 2C144180134E; Tue, 19 Sep 2023 09:59:28 +0200 (CEST) Date: Tue, 19 Sep 2023 09:59:28 +0200 From: "Gerd Hoffmann" To: Tom Lendacky Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Erdem Aktas , James Bottomley , Min Xu , Michael Roth Subject: Re: [edk2-devel] [PATCH] OvmfPkg/ResetVector: Fix assembler bit test flag check Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FTBdtISYlwhyImweDjfkj8YZx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=fDGtQ75g; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Jul 14, 2023 at 03:28:26PM -0500, Tom Lendacky wrote: > Commit 63c50d3ff2854a76432b752af4f2a76f33ff1974 changed the check that is > used to determine if SEV-ES is active. Originally, a CMP instruction with > a supporting JZ instruction was used for the check. It was changed to use > the BT instruction but not JZ instruction. The result of a BT instruction > changes the the carry flag (CF) and not the zero flag (ZF). As a result, > the wrong condition is being checked. Update the JZ to a JNC to properly > detect if SEV-ES is active. What is the effect of this bug? Is it just the encryption sanity check being skipped? take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108817): https://edk2.groups.io/g/devel/message/108817 Mute This Topic: https://groups.io/mt/100149226/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-