From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id ECB0FAC0E92 for ; Thu, 22 Feb 2024 12:28:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MRPS2jPP4TOOS7xsBDuco9rrZqQhAqNA+xXglb2t3Q8=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1708604918; v=1; b=dxPblKNXbCA20lBtlokYNhe1CkR7O3DoyuJibnB8u/SY21+ElnBNVjQPPjidxXi+x8qxCS6U jtPubCUyCoIchloxDHMRYvFI7R5zIzeYFKrE8pPkOa4jICt0gujDF6rZ7ew1+skzVn/pg6RDewT sPi/aItp/bL86K3B8a6+JIkk= X-Received: by 127.0.0.2 with SMTP id PPmvYY7687511xRPoskMCXdE; Thu, 22 Feb 2024 04:28:38 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.11587.1708604917501357518 for ; Thu, 22 Feb 2024 04:28:37 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-gKs8EA4jNlCnBN2_TIeMKA-1; Thu, 22 Feb 2024 07:28:35 -0500 X-MC-Unique: gKs8EA4jNlCnBN2_TIeMKA-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4ACDD85A589; Thu, 22 Feb 2024 12:28:35 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.237]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2706220229A4; Thu, 22 Feb 2024 12:28:35 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D7ABB18007A1; Thu, 22 Feb 2024 13:28:33 +0100 (CET) Date: Thu, 22 Feb 2024 13:28:33 +0100 From: "Gerd Hoffmann" To: Laszlo Ersek Cc: devel@edk2.groups.io, Oliver Steffen , Rahul Kumar , Ray Ni Subject: Re: [edk2-devel] [PATCH v2 4/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to MpInitLibInitialize Message-ID: References: <20240220174939.1288689-1-kraxel@redhat.com> <20240220174939.1288689-5-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: wg7oZO0HTd69HOfnDqt8aCZDx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=dxPblKNX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > The code looks otherwise OK, but I'm not happy that > WaitLoopExecutionMode (and StartupSignalValue) are replicated over all > the HOBs, just like in v1. IMO, that will only make it harder for others > to understand the code / data structures, and therefore it increases > technical debt. > > I understand that Ray is OK with that, so I won't try to block the > patch, but I'm not comfortable giving it an R-b myself, due to the > increase in technical debt. I can try to address that, but this certainly will be a separate patch. Given that the HOB structure is defined in locally in the library I assume this is considered private and there are no compatibility concerns when changing the structs? Any preference where the fields should be moved to? PCD? Separate HOB? Something else? take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115813): https://edk2.groups.io/g/devel/message/115813 Mute This Topic: https://groups.io/mt/104472311/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-