From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4392BD81163 for ; Fri, 15 Mar 2024 09:09:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=89CptJVYI2OgCbm4fv1oVGcIgJHzWIpvW+19NSFHgP0=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1710493764; v=1; b=ARTO0ZiW3UgO2f8Ba0L9M14rEdauRXJ+Q5itF0b1LVSVD0V8/dqk9oP3tXZ6/zWbOuxgJQJx 1RA0Zs5lTqMdaiuT0WLQ6eTq4TMda75lSKAsqa8eImG38jk/ax5CGcs+MIZptFHiplPV49mZ4xs u1YHwzYQmrvnhjypAOkpKmH6oAzpSTOUAorYnyCsDcgwRb/jOCW5IP+2pCmMFrf8pV6UnJDq9yt Ij+qyYx480AdFCF/i+4Ec0pKN2LaLxmqdPGQG1utF5Vp9mSzT2Alj+I5pViWM2gmFCsENsyNIcH wOytMyyg2otIE8KGFdo+uPkYMbKoqVBXujoojKTDOOzOQ== X-Received: by 127.0.0.2 with SMTP id el6lYY7687511xeKWtmHtVWZ; Fri, 15 Mar 2024 02:09:24 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.17125.1710493764062116466 for ; Fri, 15 Mar 2024 02:09:24 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-28-p6e84lhqMJKMJxg589Zh6w-1; Fri, 15 Mar 2024 05:09:19 -0400 X-MC-Unique: p6e84lhqMJKMJxg589Zh6w-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 14A748007A1; Fri, 15 Mar 2024 09:09:19 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4EC3F40C6CB1; Fri, 15 Mar 2024 09:09:18 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0B4EA1800DD4; Fri, 15 Mar 2024 10:09:17 +0100 (CET) Date: Fri, 15 Mar 2024 10:09:16 +0100 From: "Gerd Hoffmann" To: Chao Li Cc: devel@edk2.groups.io, Ray Ni , Rahul Kumar Subject: Re: [edk2-devel] [PATCH v1 09/26] UefiCpuPkg: Added a new PCD named PcdCpuMmuIsEnabled Message-ID: References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093817.1253752-1-lichao@loongson.cn> MIME-Version: 1.0 In-Reply-To: <20240311093817.1253752-1-lichao@loongson.cn> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 15 Mar 2024 02:09:24 -0700 Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 7VUcZ63qifqBnFsXkNjsysBbx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ARTO0ZiW; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On Mon, Mar 11, 2024 at 05:38:17PM +0800, Chao Li wrote: > Added PcdCpuMmuIsEnabled to instruct that the CPU MMU is enabled. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 > > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Signed-off-by: Chao Li > --- > UefiCpuPkg/UefiCpuPkg.dec | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec > index a23a90ec99..b27cf88aee 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dec > +++ b/UefiCpuPkg/UefiCpuPkg.dec > @@ -486,5 +486,10 @@ [PcdsDynamic, PcdsDynamicEx] > # @Prompt GHCB Hypervisor Features > gUefiCpuPkgTokenSpaceGuid.PcdGhcbHypervisorFeatures|0x0|UINT64|0x60000018 > > + ## This dynamic PCD indicates whether CPU MMU is enabled. > + # TRUE - CPU MMU is enabled. > + # FASLE - CPU MMU have not enabled. > + gUefiCpuPkgTokenSpaceGuid.PcdCpuMmuIsEnabled|FALSE|BOOLEAN|0x60000023 Why create a PCD for this? Can't you simply read the control register to figure whenever paging is enabled or not? take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116787): https://edk2.groups.io/g/devel/message/116787 Mute This Topic: https://groups.io/mt/104859880/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-