public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Gupta, Pankaj" <pankaj.gupta@amd.com>
Cc: devel@edk2.groups.io, "Ard Biesheuvel" <ardb@kernel.org>,
	"Stefan Berger" <stefanb@linux.ibm.com>,
	"Julien Grall" <julien@xen.org>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
	"Jordan Justen" <jordan.l.justen@intel.com>,
	"Pawel Polawski" <ppolawsk@redhat.com>,
	"Oliver Steffen" <osteffen@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Jiewen Yao" <jiewen.yao@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/4] OvmfPkg: add virtio serial driver
Date: Thu, 20 Apr 2023 13:46:10 +0200	[thread overview]
Message-ID: <ibqa3z4soqeockeunmlbee7lo4d6mursw6js7xx7xn7zovdcis@o4p34qltb43d> (raw)
In-Reply-To: <75755155-c93a-bc72-5ef7-58ad1a9c9a73@amd.com>

  Hi,

> > libvirt snippet (add to <devices>):
> > 
> >      <console type='pty'>
> >        <target type='virtio' port='0'/>
> >      </console>
> Was thinking about the motivation to add the virtio serial device.
> 
> AFAIU this can provide a console in bios/early boot based on "virtio".
> Currently we can only get it with emulated PTY device which is slow
> because of frequent VMEXITS because of ioport write?

Yes, it has better performance because it wouldn't vmexit for every
single character.

Dawback is that it wouldn't work for early logging, the driver loads
relatively late because it depends on pci and virtio.  So if the
firmware panics in SEC or PEI you wouldn't see that.

So for debug logging it isn't the best choice, for efi shell and grub it
works fine.

> Or is there any other reason (e.g across the ARCH support) to add this
> support in UEFI ?

Should work on all architectures, although it needs some platform setup
code to have the firmware actually bind the firmware console to it (see
patch #4).

Another nice property of a virtio console is that systemd will spawn a
getty there even if it is not explicitly configured as console device.

take care,
  Gerd


  reply	other threads:[~2023-04-20 11:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17  9:03 [PATCH 0/4] OvmfPkg: add virtio serial driver Gerd Hoffmann
2023-04-17  9:03 ` [PATCH 1/4] OvmfPkg: add IndustryStandard/VirtioSerial.h Gerd Hoffmann
2023-04-17  9:03 ` [PATCH 2/4] OvmfPkg/VirtioSerialDxe: add driver Gerd Hoffmann
2023-04-17  9:03 ` [PATCH 3/4] OvmfPkg/VirtioSerialDxe: wire up in OvmfPkg* Gerd Hoffmann
2023-04-17  9:03 ` [PATCH 4/4] OvmfPkg/PlatformBootManagerLib: setup virtio serial console Gerd Hoffmann
2023-04-18 15:46 ` [PATCH 0/4] OvmfPkg: add virtio serial driver Ard Biesheuvel
2023-04-19  6:18   ` Gerd Hoffmann
2023-04-20  9:52     ` [edk2-devel] " Gupta, Pankaj
2023-04-20 11:46       ` Gerd Hoffmann [this message]
2023-04-20 13:31         ` Gupta, Pankaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ibqa3z4soqeockeunmlbee7lo4d6mursw6js7xx7xn7zovdcis@o4p34qltb43d \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox